[flutter_tools] Handle errors on the std{out,err}.done future

[zanderso]

Description

stdout and stderr can put errors on their respective done futures. This PR catches those errors to avoid the tool crashing on a write to stdout or stderr.

Related Issues

Crash seen in crash logging.

Tests

I added the following tests:

Added a test logger_test.dart

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

• No, no existing tests failed, so this is not a breaking change.

[jonahwilliams]

LGTM with nits

For my own understanding: something goes wrong (like a broken pipe?) and stdout and/or stderr signal this by completing done with an exception. If we write to them after this point, we get a different exception?

[jonahwilliams]

I like this pattern

[zanderso]

For my own understanding: something goes wrong (like a broken pipe?) and stdout and/or stderr signal this by completing done with an exception. If we write to them after this point, we get a different exception?

Right, we'd get a StateError. I added some comments to explain.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.