Skip to content

[flutter_tools] configure dwds to not serve devtools#52284

Merged
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:disable_dev_tools
Mar 10, 2020
Merged

[flutter_tools] configure dwds to not serve devtools#52284
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:disable_dev_tools

Conversation

@jonahwilliams
Copy link
Copy Markdown
Contributor

Description

This isn't necessary for any current functionality. Fixes #52269

@fluttergithubbot
Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 10, 2020
@jonahwilliams jonahwilliams requested a review from jmagman March 10, 2020 02:14
Copy link
Copy Markdown
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@NicTanghe
Copy link
Copy Markdown

Hello i must say i'm using the latest beta channel build and i'm still getting.


Oops; flutter has exited unexpectedly: "NoSuchMethodError: The method 'toFilePath' was called  
on null.
Receiver: null
Tried calling: toFilePath()".

@jonahwilliams
Copy link
Copy Markdown
Contributor Author

Hello i must say i'm using the latest beta channel build

The latest beta channel is older than this PR

@NicTanghe
Copy link
Copy Markdown

he latest release is from 17 march that is newer or is it older in another way ?

@jmagman
Copy link
Copy Markdown
Member

jmagman commented Mar 19, 2020

This change is available in 1.15.19. So at the moment it's on master and dev. See https://flutter.dev/docs/development/tools/sdk/releases.

@nttd-jieyangxu
Copy link
Copy Markdown

nttd-jieyangxu commented Mar 20, 2020

Im sorry, but i try two dev versions for flutter web, that still happen. anything wrong?
dev version: 1.5.22 and 1.16.1


Downloading Web SDK... 8.2s
Launching lib\main.dart on Chrome in debug mode...
Syncing files to device Chrome...
13,882ms (!)
ERROR - 2020-03-20 11:06:30.426168
GET /dwds/src/injected/client.js
Error thrown by handler.
NoSuchMethodError: The method 'toFilePath' was called on null.
Receiver: null
Tried calling: toFilePath()
dart:core Object.noSuchMethod
package:dwds/src/handlers/injected_handler.dart 35:39 createInjectedHandler..

flutter_doctor

@jonahwilliams
Copy link
Copy Markdown
Contributor Author

You're right, that is actually a different issue. Opening a new PR

@nttd-jieyangxu
Copy link
Copy Markdown

nttd-jieyangxu commented Mar 20, 2020

You're right, that is actually a different issue. Opening a new PR

thank you! the new PR foe web
flutter/devtools#1752

@jonahwilliams
Copy link
Copy Markdown
Contributor Author

#52914

@AttSee
Copy link
Copy Markdown

AttSee commented Mar 20, 2020

Launching lib/main.dart on Chrome in debug mode...
NoSuchMethodError: The method 'toFilePath' was called on null.
Receiver: null
Tried calling: toFilePath()
Exited (sigterm)

1.15.17 beta

@flutter flutter locked as off-topic and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebAssetServer.start > serveDevTools crash: NoSuchMethodError: The method 'toFilePath' was called on null.

7 participants