[flutter_tools] throw exception instead of string from startApp#52365
Merged
jonahwilliams merged 4 commits intoflutter:masterfrom Mar 11, 2020
Merged
[flutter_tools] throw exception instead of string from startApp#52365jonahwilliams merged 4 commits intoflutter:masterfrom
jonahwilliams merged 4 commits intoflutter:masterfrom
Conversation
fluttergithubbot
added
the
tool
added 2 commits
March 10, 2020 16:17
…r into profile_on_emulator
zanderso
approved these changes
Mar 11, 2020
Member
|
Related: #52272 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update to throw exception and add test case. We were catching
on Exception, so the string was slipping through - but this is still a fatal error so we need to exit.