Skip to content

Update fuchsia remote debug protocol to use package:test shim instead of package:test_api#52706

Merged
jonahwilliams merged 3 commits intoflutter:masterfrom
jonahwilliams:fix_common_frdb
Mar 18, 2020
Merged

Update fuchsia remote debug protocol to use package:test shim instead of package:test_api#52706
jonahwilliams merged 3 commits intoflutter:masterfrom
jonahwilliams:fix_common_frdb

Conversation

@jonahwilliams
Copy link
Copy Markdown
Contributor

@jonahwilliams jonahwilliams commented Mar 17, 2020

Description

This is necessary to ensure the tests can run in google3. https://b.corp.google.com/issues/151657461

@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Mar 17, 2020
@jonahwilliams jonahwilliams changed the title Fix test version Update fuchsia remote debug protocol to use package:test shim instead of package:test_api Mar 18, 2020
@jonahwilliams jonahwilliams marked this pull request as ready for review March 18, 2020 14:19
@fluttergithubbot
Copy link
Copy Markdown
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jonahwilliams jonahwilliams requested a review from zanderso March 18, 2020 14:21
Copy link
Copy Markdown
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@jonahwilliams jonahwilliams merged commit da0788a into flutter:master Mar 18, 2020
@jonahwilliams jonahwilliams deleted the fix_common_frdb branch March 18, 2020 16:12
@lock
Copy link
Copy Markdown

lock Bot commented Apr 2, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@lock lock Bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants