Skip to content

[flutter_tool] remove extra usage of .packages in vmservice APIs#52845

Merged
jonahwilliams merged 2 commits intoflutter:masterfrom
jonahwilliams:reduce_package_uri_usage
Mar 19, 2020
Merged

[flutter_tool] remove extra usage of .packages in vmservice APIs#52845
jonahwilliams merged 2 commits intoflutter:masterfrom
jonahwilliams:reduce_package_uri_usage

Conversation

@jonahwilliams
Copy link
Copy Markdown
Contributor

Description

The .packages is no longer needed since we precompile to kernel on the host. This requires Requires flutter/engine#17195 first

#8502

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 18, 2020
@jonahwilliams
Copy link
Copy Markdown
Contributor Author

flutter/engine#17195 landed, waiting for roll

Copy link
Copy Markdown

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit fe31014 into flutter:master Mar 19, 2020
@jonahwilliams jonahwilliams deleted the reduce_package_uri_usage branch March 19, 2020 16:36
@lock
Copy link
Copy Markdown

lock Bot commented Apr 2, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@lock lock Bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants