Remove use of "implements Function" in tests.#53113
Merged
ferhatb merged 1 commit intoflutter:masterfrom Mar 23, 2020
Merged
Conversation
yjbanov
approved these changes
Mar 23, 2020
Member
|
This looks like something that could be achieved with some Mockito mocks, instead of rolling our own function-like handler? |
Contributor
|
@vsmenon @sigmundch Surprisingly this only failed on the Web, not on mobile. Is there a discrepancy between Web and VM we should be aware of? |
|
@yjbanov - web and mobile should behave the same here. Are these files exercised in both places? Do both have consistent settings wrt failing on warnings? fyi - @johnniwinther |
Contributor
Yes.
/cc @jonahwilliams do you know? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
implements/extends Function is being deprecated. This PR prepares flutter code base.
Related Issues
Example Dart roll failure: https://cirrus-ci.com/task/4670267658076160
Tests
Already covered by icon_button_test and implicit_animations_test.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].