Skip to content

Remove use of "implements Function" in tests.#53113

Merged
ferhatb merged 1 commit intoflutter:masterfrom
ferhatb:impl_function
Mar 23, 2020
Merged

Remove use of "implements Function" in tests.#53113
ferhatb merged 1 commit intoflutter:masterfrom
ferhatb:impl_function

Conversation

@ferhatb
Copy link
Copy Markdown
Contributor

@ferhatb ferhatb commented Mar 23, 2020

Description

implements/extends Function is being deprecated. This PR prepares flutter code base.

Related Issues

Example Dart roll failure: https://cirrus-ci.com/task/4670267658076160

Tests

Already covered by icon_button_test and implicit_animations_test.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@ferhatb ferhatb requested a review from yjbanov March 23, 2020 17:45
@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 23, 2020
@ferhatb ferhatb requested a review from ditman March 23, 2020 18:03
Copy link
Copy Markdown
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ditman
Copy link
Copy Markdown
Member

ditman commented Mar 23, 2020

This looks like something that could be achieved with some Mockito mocks, instead of rolling our own function-like handler?

@yjbanov
Copy link
Copy Markdown
Contributor

yjbanov commented Mar 23, 2020

@vsmenon @sigmundch Surprisingly this only failed on the Web, not on mobile. Is there a discrepancy between Web and VM we should be aware of?

@vsmenon
Copy link
Copy Markdown

vsmenon commented Mar 23, 2020

@yjbanov - web and mobile should behave the same here. Are these files exercised in both places? Do both have consistent settings wrt failing on warnings?

fyi - @johnniwinther

@yjbanov
Copy link
Copy Markdown
Contributor

yjbanov commented Mar 23, 2020

Are these files exercised in both places?

Yes.

Do both have consistent settings wrt failing on warnings?

/cc @jonahwilliams do you know?

@ferhatb ferhatb merged commit fed6887 into flutter:master Mar 23, 2020
@ferhatb ferhatb deleted the impl_function branch March 23, 2020 19:41
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants