[flutter_tools] Prepare for OSError to implement Exception#53258
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Mar 26, 2020
zanderso:ignore-oserror-dead-code
Merged
[flutter_tools] Prepare for OSError to implement Exception#53258fluttergithubbot merged 1 commit intoflutter:masterfrom zanderso:ignore-oserror-dead-code
fluttergithubbot merged 1 commit intoflutter:masterfrom
zanderso:ignore-oserror-dead-code
Conversation
zanderso
added
the
tool
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
dnfield
reviewed
Mar 25, 2020
| } on Exception catch (_) { | ||
| // handled by checking the exit code. | ||
| } on OSError catch (_) { | ||
| } on OSError catch (_) { // ignore: dead_code_on_catch_subtype |
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 11, 2020
This is a reland of ae392b8 flutter/flutter#53258 will be landed first to unblock the roll. Original change's description: > [dart:io] Making OSError implements Exception > > Bug: #40934 > Change-Id: Icff457333bd570d81cdf9c3136ee4fe1cadfaae8 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139406 > Reviewed-by: Zach Anderson <zra@google.com> > Reviewed-by: Siva Annamalai <asiva@google.com> > Commit-Queue: Zichang Guo <zichangguo@google.com> Bug: #40934 Change-Id: Ibc17c0a5717c2005898ce279d4d16edbdbbf44fc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140910 Commit-Queue: Zichang Guo <zichangguo@google.com> Reviewed-by: Siva Annamalai <asiva@google.com> Reviewed-by: Jonas Termansen <sortie@google.com> Reviewed-by: Zach Anderson <zra@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSErrorwill soon implementException. Prepare for this by ignoring analyzer warnings about dead code in catch clauses that catch bothExceptionandOSError.@zichangg