Mark stable devicelab tests as unflaky#53310
Merged
jmagman merged 1 commit intoflutter:masterfrom Mar 25, 2020
Merged
Conversation
jmagman
added
c: contributor-productivity
jmagman
commented
Mar 25, 2020
| Measures the runtime performance of platform views in the Complex Layout sample app on Android. | ||
| stage: devicelab | ||
| required_agent_capabilities: ["linux/android"] | ||
| flaky: true |
| required_agent_capabilities: ["mac/ios", "ios/gl-render-image"] | ||
| #TODO(cyanglaz): The flaky flag is added because it is the first screenshot test we added. | ||
| # Remove the flaky flag when we are sure the test is stable. | ||
| flaky: true |
Contributor
There was a problem hiding this comment.
This test passed but doesn't actually WAI. I should've put a note there. It doesn't hurt to enable it tho as it will always pass.
Member
Author
There was a problem hiding this comment.
You sure? I'm happy to revert these lines.
Contributor
There was a problem hiding this comment.
I will send a revert PR with a revised todo message.
| description: > | ||
| Builds an APK with a --dart-define and verifies it can be used as a constant | ||
| stage: devicelab | ||
| flaky: true |
blasten
approved these changes
Mar 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These all look stable in devicelab, remove flaky so we get notified on failures.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change