Skip to content

[web] Unskip assertions test. Update for latest stack trace format.#53795

Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom
ferhatb:stack_trace_format
Apr 2, 2020
Merged

[web] Unskip assertions test. Update for latest stack trace format.#53795
fluttergithubbot merged 2 commits intoflutter:masterfrom
ferhatb:stack_trace_format

Conversation

@ferhatb
Copy link
Copy Markdown
Contributor

@ferhatb ferhatb commented Apr 2, 2020

Description

Unskip tests by fixing debugPrintStack for new format.

Related Issues

Fixes #53712

Tests

assertions_test updated.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@ferhatb ferhatb requested review from Piinks and yjbanov April 2, 2020 00:29
@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 2, 2020
@jonahwilliams
Copy link
Copy Markdown
Contributor

Does this work with stack traces in flutter run? Unfortunately the stack traces are different between the tests which still use build_runner and flutter run which uses the frontend_server.

See also: #52685

@ferhatb
Copy link
Copy Markdown
Contributor Author

ferhatb commented Apr 2, 2020

Does this work with stack traces in flutter run? Unfortunately the stack traces are different between the tests which still use build_runner and flutter run which uses the frontend_server.

See also: #52685

Updated code to handle both build_runner and frontend_server based.

@ferhatb ferhatb added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 2, 2020
Copy link
Copy Markdown
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix!

Piinks added a commit to Piinks/flutter that referenced this pull request Apr 2, 2020
@fluttergithubbot fluttergithubbot merged commit 40aea47 into flutter:master Apr 2, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expected stack trace format for web is broken

6 participants