[camera] fix RECORD_AUDIO permission on Android when there is no permission #10424

agrapine · 2025-11-14T09:36:07Z

Allows to record video without audio when we init the CameraController with enableAudio=false

 final controller = CameraController(
        camera.first,
        ResolutionPreset.high,
        enableAudio: false,
      );

Related issue: flutter/flutter#175020

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

flutter-dashboard · 2025-11-14T09:36:10Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gemini-code-assist

Code Review

This pull request aims to fix how audio recording is handled when permissions are missing or audio is disabled. While the intent is correct, the implementation contains a critical logical error that would mute audio when it should be enabled. Additionally, the corresponding unit tests have not been updated to reflect the new logic, which would cause them to fail. I've provided a detailed review comment on the withAudioEnabled method with a suggested fix and a reference to the testing guidelines.

...droid_camerax/android/src/main/java/io/flutter/plugins/camerax/PendingRecordingProxyApi.java

camsim99

Wow thanks so much for catching + fixing this subtle bug!

Before we land this, we'll need to test this. You'll just need to add/modify tests in PendingRecordingTest.java.

...droid_camerax/android/src/main/java/io/flutter/plugins/camerax/PendingRecordingProxyApi.java

stuartmorgan-g · 2025-11-18T16:17:04Z

In the future, please do not delete the checklist that is in the PR template; it is there for a reason. This PR is missing required elements described in the checklist (I’ve restored it to the PR description), which need to be addressed before it moves forward with review.

I am marking the PR as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.

…o/flutter/plugins/camerax/PendingRecordingProxyApi.java Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>

camsim99

Looking good thanks! Just two some small changes, then we'll just need a second review.

packages/camera/camera_android_camerax/CHANGELOG.md

camsim99 · 2025-11-24T16:54:15Z

...a_android_camerax/android/src/test/java/io/flutter/plugins/camerax/PendingRecordingTest.java

          .thenAnswer((Answer<Integer>) invocation -> PackageManager.PERMISSION_DENIED);

-      when(instance.withAudioEnabled(true)).thenReturn(newInstance);
+      when(instance.withAudioEnabled(true)).thenReturn(instance);


Can you make a separate test with these changes? This (withAudioEnabled_doesNotEnableAudioWhenRequestedAndPermissionNotGranted) is supposed to test when audio IS requested but permission is not granted.

🤔 i might be missing something. i'm falling to see the issue. could you help?

I believe the original test was testing an invalid assumption. withAudioEnabled_doesNotEnableAudioWhenRequestedAndPermissionNotGranted is testing when audio IS requested with permission denied.

I don't believe so. withAudioEnabled takes a boolean initialMuted, which should be false to request audio. I'm asking if you can separate this out into two tests--one withAudioEnabled_doesNotEnableAudioWhenRequestedAndPermissionNotGranted (this one without changes) and another (for example) withAudioEnabled_doesNotEnableAudioWhenNotRequestedAndPermissionNotGranted (one that tests the case that this PR addresses).

Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>

…r#10510) flutter/flutter@c8cfb2b...3f553f6 2025-11-24 engine-flutter-autoroll@skia.org Roll Skia from 1cbc0e6a7d21 to 43d2020be565 (7 revisions) (flutter/flutter#179010) 2025-11-24 matt.kosarek@canonical.com Potentially fixing the flakiness in win32 windowing tests, but it needs some running (flutter/flutter#178499) 2025-11-24 engine-flutter-autoroll@skia.org Roll Skia from ee2cd2c06cf7 to 1cbc0e6a7d21 (1 revision) (flutter/flutter#178995) 2025-11-24 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from lJTlAwQY4MnuRuORC... to pOO9Jl9HTLsEmks6y... (flutter/flutter#178994) 2025-11-23 engine-flutter-autoroll@skia.org Roll Dart SDK from a1422c6f8aa1 to 24cc9a740bd3 (1 revision) (flutter/flutter#178992) 2025-11-23 engine-flutter-autoroll@skia.org Roll Skia from 6592e75d6f7e to ee2cd2c06cf7 (1 revision) (flutter/flutter#178990) 2025-11-23 engine-flutter-autoroll@skia.org Roll Skia from fb6c00107a51 to 6592e75d6f7e (5 revisions) (flutter/flutter#178985) 2025-11-22 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 4ul9jvZ7jnDGIjtCD... to lJTlAwQY4MnuRuORC... (flutter/flutter#178971) 2025-11-22 engine-flutter-autoroll@skia.org Roll Dart SDK from c44cf2015e3d to a1422c6f8aa1 (2 revisions) (flutter/flutter#178968) 2025-11-22 engine-flutter-autoroll@skia.org Roll Skia from 3018c3053490 to fb6c00107a51 (4 revisions) (flutter/flutter#178952) 2025-11-22 engine-flutter-autoroll@skia.org Roll Dart SDK from 5af71c736b0a to c44cf2015e3d (1 revision) (flutter/flutter#178953) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Last bump to robolectric. The rest were previously done by dependabot. Partially Addresses flutter/flutter#177674 Partially Addresses flutter/flutter#163071 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

Makes the analysis options changes described in flutter/flutter#178827: - Adding [omit_obvious_local_variable_types](https://dart.dev/tools/linter-rules/omit_obvious_local_variable_types) - Adding [specify_nonobvious_local_variable_types](https://dart.dev/tools/linter-rules/specify_nonobvious_local_variable_types) - Adding [specify_nonobvious_property_types](https://dart.dev/tools/linter-rules/specify_nonobvious_property_types) - Adding [type_annotate_public_apis](https://dart.dev/tools/linter-rules/type_annotate_public_apis) - Removing [always_specify_types](https://dart.dev/tools/linter-rules/always_specify_types) After those changes, makes the following repo-wide changes: - `dart fix --apply` in all packages and in script/tool/ - `dart format` in all packages and in script/tool/ - `update-excerpts` repo tooling command to update excerpts based on the changes to their sources Also updates the min Flutter/Dart SDK version to 3.35/3.9 for the following packages, to avoid `analyze` failures in the `N-2` legacy analysis run due to what appears to be a 3.9 change in what the Dart analyzer continues to be an obvious local type in loop iterations: - go_router - google_fonts - google_identity_services_web - google_maps_flutter_web - local_auth_platform_interface - metrics_center - multicast_dns - pigeon - rfw - shared_preferences - two_dimensional_scrollables - vector_graphics_compiler - mustache_template - path_parsing Because this is causing a significant amount of format churn already, I took this opportunity to update the repository tooling to a min Dart SDK of 3.8 (the N-2 stable version, so the earliest version we need the tooling to support) to pick up the new format style, so the amount of automated formatter change is higher in script/tool/ than in the packages. This does contain two manual changes (other than the repo tooling min version): - flutter@d700b45 changes `dynamic` to `Object?` in a few places where `dynamic` caused analyzer warnings under the new rule set. - Updates the repo tooling to ignore `.dart_tool/` when looking for unexpected local `analysis_options.yaml` files, to fix issues running the repo tool's `analyze` command locally based on recent changes in `dart` behavior. This does not include any CHANGELOG or version updates; even though we normally version any changes to production code, mass automated changes like this aren't worth the churn of releasing. This includes changes to lib/example/main.dart and to README.md excerpts; while the style changes will be user-visible on pub.dev, it's fine for those changes to wait for the next release of each package. Part of flutter/flutter#178827

Replaces the full build-and-analyze version of `pod lib lint` with the `--quick` version. This means that this step no longer does native code analysis (which `analyze` covers), so it no longer needs an exclusion list for packages with warnings. As a result of this change, flutter/packages no longer has a dependency on the version of Flutter that was published to CocoaPods to facilitate podspec testing. Fixes flutter/flutter#178806

camsim99

Updated test LGTM! @jesswrd can you give this a second pass?

…is no permission (flutter/packages#10424)

flutter/packages@5d8d954...b505d41 2025-11-26 dasyad00@gmail.com [camera_android_camerax] use MediaSettings::fps for image preview, streaming, and video recording (flutter/packages#10301) 2025-11-26 stuartmorgan@google.com [various] Update READMEs to reflect current OS support (flutter/packages#10470) 2025-11-26 engine-flutter-autoroll@skia.org Roll Flutter from 3f553f6 to 7b98d50 (30 revisions) (flutter/packages#10523) 2025-11-26 alex@swipelab.co [camera] fix RECORD_AUDIO permission on Android when there is no permission (flutter/packages#10424) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#179188) flutter/packages@5d8d954...b505d41 2025-11-26 dasyad00@gmail.com [camera_android_camerax] use MediaSettings::fps for image preview, streaming, and video recording (flutter/packages#10301) 2025-11-26 stuartmorgan@google.com [various] Update READMEs to reflect current OS support (flutter/packages#10470) 2025-11-26 engine-flutter-autoroll@skia.org Roll Flutter from 3f553f6 to 7b98d50 (30 revisions) (flutter/packages#10523) 2025-11-26 alex@swipelab.co [camera] fix RECORD_AUDIO permission on Android when there is no permission (flutter/packages#10424) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

agrapine requested a review from camsim99 as a code owner November 14, 2025 09:36

github-actions bot added p: camera platform-android labels Nov 14, 2025

gemini-code-assist bot reviewed Nov 14, 2025

View reviewed changes

...droid_camerax/android/src/main/java/io/flutter/plugins/camerax/PendingRecordingProxyApi.java Show resolved Hide resolved

agrapine force-pushed the fix/record_audio_permission branch 3 times, most recently from 5e57600 to e443aed Compare November 14, 2025 10:21

agrapine commented Nov 17, 2025

View reviewed changes

...droid_camerax/android/src/main/java/io/flutter/plugins/camerax/PendingRecordingProxyApi.java Show resolved Hide resolved

camsim99 reviewed Nov 17, 2025

View reviewed changes

...droid_camerax/android/src/main/java/io/flutter/plugins/camerax/PendingRecordingProxyApi.java Show resolved Hide resolved

stuartmorgan-g marked this pull request as draft November 18, 2025 16:17

agrapine changed the title ~~fix RECORD_AUDIO permission on Android when there is no permission~~ [camera] fix RECORD_AUDIO permission on Android when there is no permission Nov 24, 2025

agrapine and others added 2 commits November 24, 2025 15:27

fix RECORD_AUDIO permission on Android when there is no permission

752c5df

Update packages/camera/camera_android_camerax/android/src/main/java/i…

61a6b51

…o/flutter/plugins/camerax/PendingRecordingProxyApi.java Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>

agrapine force-pushed the fix/record_audio_permission branch from 4c27904 to 61a6b51 Compare November 24, 2025 13:27

agrapine added 3 commits November 24, 2025 15:42

PR checklist

a615897

updated test

481ab0f

format

c897f93

agrapine marked this pull request as ready for review November 24, 2025 14:27

agrapine requested a review from camsim99 November 24, 2025 14:27

Trigger Build

3ab8b9f

camsim99 reviewed Nov 24, 2025

View reviewed changes

camsim99 requested a review from jesswrd November 24, 2025 16:55

camsim99 mentioned this pull request Nov 24, 2025

fix SecurityException when trying to record video with audio disabled #10498

Closed

11 tasks

agrapine and others added 5 commits November 25, 2025 11:10

Update packages/camera/camera_android_camerax/CHANGELOG.md

6d556c1

Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>

camsim99 approved these changes Nov 26, 2025

View reviewed changes

jesswrd approved these changes Nov 26, 2025

View reviewed changes

camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 26, 2025

auto-submit bot merged commit 47ffbc5 into flutter:main Nov 26, 2025
80 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 27, 2025

47ffbc54e [camera] fix RECORD_AUDIO permission on Android when there …

a7c0016

…is no permission (flutter/packages#10424)

engine-flutter-autoroll mentioned this pull request Nov 27, 2025

Roll Packages from 5d8d954b7c5e to b505d41ade71 (4 revisions) flutter/flutter#179188

Merged

[camera] fix RECORD_AUDIO permission on Android when there is no permission #10424

[camera] fix RECORD_AUDIO permission on Android when there is no permission #10424

Conversation

agrapine commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

flutter-dashboard bot commented Nov 14, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stuartmorgan-g commented Nov 18, 2025

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

camsim99 Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

agrapine Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

agrapine Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

camsim99 Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

agrapine Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

agrapine commented Nov 14, 2025 •

edited

Loading