[vector_graphics] add imageBuilder property to VectorGraphic#11094
Merged
gaaclarke merged 10 commits intoflutter:mainfrom Apr 28, 2026
Merged
[vector_graphics] add imageBuilder property to VectorGraphic#11094gaaclarke merged 10 commits intoflutter:mainfrom
gaaclarke merged 10 commits intoflutter:mainfrom
Conversation
github-actions
Bot
added
p: vector_graphics
p: flutter_svg
triage-engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully introduces the imageBuilder property to both SvgPicture and VectorGraphic widgets. This addition completes the builder pattern (placeholder, error, success) for these widgets, allowing developers to wrap the successfully loaded vector graphic with decorations or other widgets only when the image is available. The implementation is consistent across both packages, includes clear documentation, and is well-tested with new test cases in the vector_graphics package. The code follows Flutter best practices for widget builders and maintains backward compatibility.
suojae
force-pushed
the
feat/add-image-builder
branch
from
d91da1f to
3ca0245
Compare
suojae
changed the title
Adds an optional imageBuilder callback that wraps the loaded vector graphic widget, enabling post-load decoration such as borders or gesture detectors without affecting placeholder or error states. Resolves flutter/flutter#182635
suojae
force-pushed
the
feat/add-image-builder
branch
from
3ca0245 to
bcf23ed
Compare
stuartmorgan-g
changed the title
domesticmouse
approved these changes
Feb 26, 2026
|
LGTM! |
jtmcdole
requested changes
Mar 10, 2026
| repository: https://github.com/flutter/packages/tree/main/packages/vector_graphics | ||
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+vector_graphics%22 | ||
| version: 1.1.19 | ||
| version: 1.1.20 |
Member
There was a problem hiding this comment.
new exposed type and new parameter to method as a new feature requires the MINOR number to be incremented.
Contributor
Author
There was a problem hiding this comment.
Thanks. I've bumped the version to 1.2.0 (minor). Also merge upstream.
jtmcdole
approved these changes
Apr 13, 2026
Member
|
@jtmcdole @domesticmouse do we want to put autosubmit on this? |
This was referenced Apr 29, 2026
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Apr 29, 2026
…er#185748) flutter/packages@ba80f8f...cde5b36 2026-04-29 stuartmorgan@google.com [file_selector] Switch to Kotlin Pigeon (flutter/packages#11479) 2026-04-29 stuartmorgan@google.com [image_picker] Switch to Kotlin Pigeon (flutter/packages#11504) 2026-04-29 stuartmorgan@google.com [quick_actions] Switch to Kotlin Pigeon (flutter/packages#11507) 2026-04-29 git@reb0.org [pigeon] fix: Apply correct ThrowError success callback (flutter/packages#11585) 2026-04-29 nateshmbhat1@gmail.com [video_player_platform_interface] Add video track selection support (flutter/packages#11474) 2026-04-29 katelovett@google.com Update git ignore for personal/iterating on agent skills and rules (flutter/packages#11600) 2026-04-29 stuartmorgan@google.com [file_selector] Update Windows example for deprecations (flutter/packages#11570) 2026-04-29 git@reb0.org [various] Upgrade googletest to v1.15.2 (flutter/packages#11586) 2026-04-28 engine-flutter-autoroll@skia.org Roll Flutter (stable) from cc0734a to 02085fe (2 revisions) (flutter/packages#11598) 2026-04-28 116356835+AbdeMohlbi@users.noreply.github.com [image_picker] Update documentation of maxDuration to reflect that it only applies to recording (flutter/packages#11417) 2026-04-28 suojae3@gmail.com [vector_graphics] add imageBuilder property to VectorGraphic (flutter/packages#11094) 2026-04-28 engine-flutter-autoroll@skia.org Roll Flutter from 61fca76 to 81bc3d6 (1 revision) (flutter/packages#11597) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related with flutter/flutter#182635
Adding an
imageBuilderproperty toVectorGraphicallows developers to wrap the successfully loaded vector graphic with decorations or interaction layers (e.g., borders, shadows, gesture detectors) only when the image is available. This completes the builder pattern alongside the existingplaceholderBuilderanderrorBuilder, giving full control over all three rendering states.Changes
VectorGraphicsImageWidgettypedefimageBuilderparameter toVectorGraphicconstructors andcreateCompatVectorGraphicVectorGraphicsImageWidgetfromvector_graphics_compat.dartimageBuilderis called on success and not during placeholder stateTest plan
imageBuilder wraps the loaded vector graphic— verifies the builder is applied on successful loadimageBuilder is not called during placeholder state— verifies the builder is skipped during loading