Skip to content

[image_picker] Update documentation of maxDuration to reflect that it only applies to recording#11417

Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom
AbdeMohlbi:issue_83630
Apr 28, 2026
Merged

[image_picker] Update documentation of maxDuration to reflect that it only applies to recording#11417
auto-submit[bot] merged 3 commits intoflutter:mainfrom
AbdeMohlbi:issue_83630

Conversation

@AbdeMohlbi
Copy link
Copy Markdown
Contributor

@AbdeMohlbi AbdeMohlbi commented Apr 2, 2026

Fixes flutter/flutter#83630

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@AbdeMohlbi AbdeMohlbi added the CICD Run CI/CD label Apr 2, 2026
@AbdeMohlbi AbdeMohlbi changed the title Update documentation of maxDuration to reflect that it only applies t… [image_picker] Update documentation of maxDuration to reflect that it only applies to recording Apr 2, 2026
@AbdeMohlbi AbdeMohlbi added CICD Run CI/CD and removed CICD Run CI/CD labels Apr 2, 2026
@AbdeMohlbi AbdeMohlbi marked this pull request as ready for review April 2, 2026 11:16
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the image_picker package to version 1.2.2 and clarifies that the maxDuration parameter applies only to video recording from the camera, not gallery selection. Feedback was provided to correct minor grammatical and spacing issues in the documentation update for maxDuration.

Comment thread packages/image_picker/image_picker/lib/image_picker.dart Outdated
@AbdeMohlbi
Copy link
Copy Markdown
Contributor Author

test exemption : this is a documentation change and does not affect the behavior of image_picker

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@AbdeMohlbi AbdeMohlbi added CICD Run CI/CD and removed CICD Run CI/CD labels Apr 2, 2026
Copy link
Copy Markdown
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 28, 2026
@auto-submit auto-submit Bot merged commit 5fca300 into flutter:main Apr 28, 2026
81 checks passed
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Apr 29, 2026
…er#185748)

flutter/packages@ba80f8f...cde5b36

2026-04-29 stuartmorgan@google.com [file_selector] Switch to Kotlin
Pigeon (flutter/packages#11479)
2026-04-29 stuartmorgan@google.com [image_picker] Switch to Kotlin
Pigeon (flutter/packages#11504)
2026-04-29 stuartmorgan@google.com [quick_actions] Switch to Kotlin
Pigeon (flutter/packages#11507)
2026-04-29 git@reb0.org [pigeon] fix: Apply correct ThrowError success
callback (flutter/packages#11585)
2026-04-29 nateshmbhat1@gmail.com [video_player_platform_interface] Add
video track selection support (flutter/packages#11474)
2026-04-29 katelovett@google.com Update git ignore for
personal/iterating on agent skills and rules (flutter/packages#11600)
2026-04-29 stuartmorgan@google.com [file_selector] Update Windows
example for deprecations (flutter/packages#11570)
2026-04-29 git@reb0.org [various] Upgrade googletest to v1.15.2
(flutter/packages#11586)
2026-04-28 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
cc0734a to 02085fe (2 revisions) (flutter/packages#11598)
2026-04-28 116356835+AbdeMohlbi@users.noreply.github.com [image_picker]
Update documentation of maxDuration to reflect that it only applies to
recording (flutter/packages#11417)
2026-04-28 suojae3@gmail.com [vector_graphics] add imageBuilder property
to VectorGraphic (flutter/packages#11094)
2026-04-28 engine-flutter-autoroll@skia.org Roll Flutter from
61fca76 to 81bc3d6 (1 revision) (flutter/packages#11597)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: image_picker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[image_picker] Update documentation of maxDuration to reflect that it only applies to recording

2 participants