[various] Upgrade googletest to v1.15.2#11586
Conversation
93f775b to
837e25a
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the googletest version to 1.15.2 across several packages, including camera_windows, file_selector, local_auth, pigeon, and url_launcher. Feedback indicates that a CHANGELOG.md entry should be added for the changes made to the pigeon package's test infrastructure.
| FetchContent_Declare( | ||
| googletest | ||
| URL https://github.com/google/googletest/archive/release-1.11.0.zip | ||
| URL https://github.com/google/googletest/archive/v1.15.2.zip |
There was a problem hiding this comment.
The changes to the test infrastructure in the pigeon package should be accompanied by a CHANGELOG.md entry, consistent with the other packages updated in this pull request (such as camera_windows and file_selector_linux).
References
- Every change to a package must be accompanied by a version bump and a CHANGELOG entry.
There was a problem hiding this comment.
Pigeons test_plugin is not published and also doesn't provide a Changelog file.
stuartmorgan-g
left a comment
There was a problem hiding this comment.
We don't do changelog entries for test-only changes.
|
version exempt: test only |
This reverts commit de9542d.
All right, I thought they are necessary, because they are part of the released package. Reverted them... |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM
@tarrinneal for a second approval
…er#185748) flutter/packages@ba80f8f...cde5b36 2026-04-29 stuartmorgan@google.com [file_selector] Switch to Kotlin Pigeon (flutter/packages#11479) 2026-04-29 stuartmorgan@google.com [image_picker] Switch to Kotlin Pigeon (flutter/packages#11504) 2026-04-29 stuartmorgan@google.com [quick_actions] Switch to Kotlin Pigeon (flutter/packages#11507) 2026-04-29 git@reb0.org [pigeon] fix: Apply correct ThrowError success callback (flutter/packages#11585) 2026-04-29 nateshmbhat1@gmail.com [video_player_platform_interface] Add video track selection support (flutter/packages#11474) 2026-04-29 katelovett@google.com Update git ignore for personal/iterating on agent skills and rules (flutter/packages#11600) 2026-04-29 stuartmorgan@google.com [file_selector] Update Windows example for deprecations (flutter/packages#11570) 2026-04-29 git@reb0.org [various] Upgrade googletest to v1.15.2 (flutter/packages#11586) 2026-04-28 engine-flutter-autoroll@skia.org Roll Flutter (stable) from cc0734a to 02085fe (2 revisions) (flutter/packages#11598) 2026-04-28 116356835+AbdeMohlbi@users.noreply.github.com [image_picker] Update documentation of maxDuration to reflect that it only applies to recording (flutter/packages#11417) 2026-04-28 suojae3@gmail.com [vector_graphics] add imageBuilder property to VectorGraphic (flutter/packages#11094) 2026-04-28 engine-flutter-autoroll@skia.org Roll Flutter from 61fca76 to 81bc3d6 (1 revision) (flutter/packages#11597) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Running e.g. pigeon tests (
packages\pigeon\tool\test.dart) with Visual Studio 2026 gives the following error:So upgrading the google tools to v1.15.2 resolves that issue as since 1.12.1 the minimum required CMake version is 3.5.
Towards flutter/flutter#185597
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2