Skip to content

[pigeon] bumps analyzer support to between 10 and 12#11358

Merged
auto-submit[bot] merged 8 commits intoflutter:mainfrom
tarrinneal:ana-12
Mar 28, 2026
Merged

[pigeon] bumps analyzer support to between 10 and 12#11358
auto-submit[bot] merged 8 commits intoflutter:mainfrom
tarrinneal:ana-12

Conversation

@tarrinneal
Copy link
Copy Markdown
Contributor

@tarrinneal tarrinneal commented Mar 26, 2026

@flutter-dashboard
Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gemini-code-assist[bot]

This comment was marked as outdated.

@tarrinneal tarrinneal added the CICD Run CI/CD label Mar 26, 2026
@tarrinneal
Copy link
Copy Markdown
Contributor Author

@stuartmorgan-g I'm not really sure how to deal with failures in all_packages. Happy to learn, but it doesn't even have a pubspec, so I don't know how to debug deps

@tarrinneal tarrinneal requested a review from chunhtai as a code owner March 27, 2026 19:08
@github-actions github-actions bot added p: go_router_builder triage-framework Should be looked at in framework triage labels Mar 27, 2026
@tarrinneal tarrinneal added CICD Run CI/CD and removed CICD Run CI/CD labels Mar 27, 2026
Copy link
Copy Markdown
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expanding the go_router_builder range (either in this PR or a prequel PR) is indeed the correct solution to that failure. This is the kind of thing we have build-all here to catch: we want people to be able to successfully use the last version of any of our packages together, so we don't want incompatible constraints in the tree.

You can add flutter/flutter#182064 to the issues fixed by this PR.

@tarrinneal tarrinneal added CICD Run CI/CD and removed CICD Run CI/CD labels Mar 27, 2026
Copy link
Copy Markdown
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I guess I didn't need to file the follow-up issue for go_router :)

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2026
@auto-submit auto-submit bot merged commit 2dc597c into flutter:main Mar 28, 2026
81 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 30, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 30, 2026
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Mar 30, 2026
flutter/packages@7ae082a...582f0e7

2026-03-30 49699333+dependabot[bot]@users.noreply.github.com Bump
lewagon/wait-on-check-action from 1.5.0 to 1.6.0 in the
all-github-actions group (flutter/packages#11388)
2026-03-28 tarrinneal@gmail.com [pigeon] bumps analyzer support to
between 10 and 12 (flutter/packages#11358)
2026-03-27 stuartmorgan@google.com Remove CODEOWNERS
(flutter/packages#11375)
2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
2c9eb20 to db50e20 (6 revisions) (flutter/packages#11380)
2026-03-27 116356835+AbdeMohlbi@users.noreply.github.com [Animations]
add example to `openCntainer` (flutter/packages#11189)
2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
2c9eb20 to db50e20 (6 revisions) (flutter/packages#11380)
2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter from
e79bf6c to fb03253 (16 revisions) (flutter/packages#11379)
2026-03-27 katelovett@google.com [two_dimensional_scrollables] Add
regression test (flutter/packages#11376)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bkonyi pushed a commit to bkonyi/flutter that referenced this pull request Mar 30, 2026
…r#184341)

flutter/packages@7ae082a...582f0e7

2026-03-30 49699333+dependabot[bot]@users.noreply.github.com Bump
lewagon/wait-on-check-action from 1.5.0 to 1.6.0 in the
all-github-actions group (flutter/packages#11388)
2026-03-28 tarrinneal@gmail.com [pigeon] bumps analyzer support to
between 10 and 12 (flutter/packages#11358)
2026-03-27 stuartmorgan@google.com Remove CODEOWNERS
(flutter/packages#11375)
2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
2c9eb20 to db50e20 (6 revisions) (flutter/packages#11380)
2026-03-27 116356835+AbdeMohlbi@users.noreply.github.com [Animations]
add example to `openCntainer` (flutter/packages#11189)
2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
2c9eb20 to db50e20 (6 revisions) (flutter/packages#11380)
2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter from
e79bf6c to fb03253 (16 revisions) (flutter/packages#11379)
2026-03-27 katelovett@google.com [two_dimensional_scrollables] Add
regression test (flutter/packages#11376)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: go_router_builder p: pigeon triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[go_router_builder] Support analyzer 11 and 12 [pigeon] Support analyzer 11 and 12 [go_router_builder] Add compatibility with analyzer 10.x

2 participants