Conversation
|
I did let Antigravity autocomplete do a bunch of the tedious format transformation via autocomplete once it figured out what I was doing. I was watching the suggested transformations, and did some spot-checking, but consider casting an eye over the parts of the file relevant to you to make sure it didn't mess up any owner mapping that I missed. |
There was a problem hiding this comment.
Code Review
This pull request replaces the CODEOWNERS file with a new SUGGESTED_REVIEWERS.md file, updating the repository's package ownership and review documentation. Corresponding changes were made to the RepoPackageInfoCheckCommand to remove logic related to CODEOWNERS validation, and various test files were updated to reflect the removal of CODEOWNERS and the inclusion of the new file. A minor improvement was suggested to correct the formatting of a package name in the new documentation file.
flutter/packages@7ae082a...582f0e7 2026-03-30 49699333+dependabot[bot]@users.noreply.github.com Bump lewagon/wait-on-check-action from 1.5.0 to 1.6.0 in the all-github-actions group (flutter/packages#11388) 2026-03-28 tarrinneal@gmail.com [pigeon] bumps analyzer support to between 10 and 12 (flutter/packages#11358) 2026-03-27 stuartmorgan@google.com Remove CODEOWNERS (flutter/packages#11375) 2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2c9eb20 to db50e20 (6 revisions) (flutter/packages#11380) 2026-03-27 116356835+AbdeMohlbi@users.noreply.github.com [Animations] add example to `openCntainer` (flutter/packages#11189) 2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2c9eb20 to db50e20 (6 revisions) (flutter/packages#11380) 2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter from e79bf6c to fb03253 (16 revisions) (flutter/packages#11379) 2026-03-27 katelovett@google.com [two_dimensional_scrollables] Add regression test (flutter/packages#11376) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#184341) flutter/packages@7ae082a...582f0e7 2026-03-30 49699333+dependabot[bot]@users.noreply.github.com Bump lewagon/wait-on-check-action from 1.5.0 to 1.6.0 in the all-github-actions group (flutter/packages#11388) 2026-03-28 tarrinneal@gmail.com [pigeon] bumps analyzer support to between 10 and 12 (flutter/packages#11358) 2026-03-27 stuartmorgan@google.com Remove CODEOWNERS (flutter/packages#11375) 2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2c9eb20 to db50e20 (6 revisions) (flutter/packages#11380) 2026-03-27 116356835+AbdeMohlbi@users.noreply.github.com [Animations] add example to `openCntainer` (flutter/packages#11189) 2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2c9eb20 to db50e20 (6 revisions) (flutter/packages#11380) 2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter from e79bf6c to fb03253 (16 revisions) (flutter/packages#11379) 2026-03-27 katelovett@google.com [two_dimensional_scrollables] Add regression test (flutter/packages#11376) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CODEOWNERS was originally added to deal with the problem of routing reviews to the right people, given the highly disparate ownership of packages in this repo. However, it has always had some significant drawbacks due the rigid implementation GitHub has for it, and some are getting worse:
stableis released) spam a lot of people who don't actually need to do the review, again wasting some people's time.Reviewerssection in a PR's sidebar often doesn't (and can't) reflect reality, making triage of current PR states much harder.The
triage-<subeam>label system that we have added more recently solves a lot of the problems that CODEOWNERS was meant to solve in the first place, without any of the downsides. It will also bring flutter/packages PR handling more in line with flutter/flutter PR handling, which makes our processes more coherent.Rather than eliminating the file entirely, I turned it into a markdown file that we can refer to. I no longer have repo tool enforcement however, to allow for changes in structure over time (e.g., for some low-traffic subteam-owned packages, they may prefer not have specific owners, and just triage to individuals in an ad-hoc way in their subteam triage). As a starting point it has the same people that the CODEOWNERs did, and we can iterate from there (or remove it later if it turns out that keeping it up to date isn't a good use of time).