[two_dimensional_scrollables] Add regression test#11376
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Mar 27, 2026
Merged
[two_dimensional_scrollables] Add regression test#11376auto-submit[bot] merged 2 commits intoflutter:mainfrom
auto-submit[bot] merged 2 commits intoflutter:mainfrom
Conversation
Contributor
Author
|
Reason for override: Just adding a test. :) |
There was a problem hiding this comment.
Code Review
This pull request adds a regression test to table_test.dart to ensure that TableView does not crash when focus shifts to an external widget while a previously focused cell is scrolled out of view. The reviewer suggests replacing magic numbers used for scroll offsets and cell extents with named constants or calculated values to improve test maintainability and readability.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 30, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 30, 2026
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 30, 2026
flutter/packages@7ae082a...582f0e7 2026-03-30 49699333+dependabot[bot]@users.noreply.github.com Bump lewagon/wait-on-check-action from 1.5.0 to 1.6.0 in the all-github-actions group (flutter/packages#11388) 2026-03-28 tarrinneal@gmail.com [pigeon] bumps analyzer support to between 10 and 12 (flutter/packages#11358) 2026-03-27 stuartmorgan@google.com Remove CODEOWNERS (flutter/packages#11375) 2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2c9eb20 to db50e20 (6 revisions) (flutter/packages#11380) 2026-03-27 116356835+AbdeMohlbi@users.noreply.github.com [Animations] add example to `openCntainer` (flutter/packages#11189) 2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2c9eb20 to db50e20 (6 revisions) (flutter/packages#11380) 2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter from e79bf6c to fb03253 (16 revisions) (flutter/packages#11379) 2026-03-27 katelovett@google.com [two_dimensional_scrollables] Add regression test (flutter/packages#11376) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bkonyi
pushed a commit
to bkonyi/flutter
that referenced
this pull request
Mar 30, 2026
…r#184341) flutter/packages@7ae082a...582f0e7 2026-03-30 49699333+dependabot[bot]@users.noreply.github.com Bump lewagon/wait-on-check-action from 1.5.0 to 1.6.0 in the all-github-actions group (flutter/packages#11388) 2026-03-28 tarrinneal@gmail.com [pigeon] bumps analyzer support to between 10 and 12 (flutter/packages#11358) 2026-03-27 stuartmorgan@google.com Remove CODEOWNERS (flutter/packages#11375) 2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2c9eb20 to db50e20 (6 revisions) (flutter/packages#11380) 2026-03-27 116356835+AbdeMohlbi@users.noreply.github.com [Animations] add example to `openCntainer` (flutter/packages#11189) 2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 2c9eb20 to db50e20 (6 revisions) (flutter/packages#11380) 2026-03-27 engine-flutter-autoroll@skia.org Roll Flutter from e79bf6c to fb03253 (16 revisions) (flutter/packages#11379) 2026-03-27 katelovett@google.com [two_dimensional_scrollables] Add regression test (flutter/packages#11376) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#137112
This PR adds a regression test for flutter/flutter#137112, where TableView would crash when focusing a widget outside of the table while a previously focused TextField inside the table was scrolled out of view.
While this issue appears to have been resolved by changes in the Flutter framework specifically flutter/flutter#135182 which addressed how focus keeps children alive in two-dimensional scrollables, this PR adds a dedicated test case to the package to ensure this behavior does not regress.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2