Skip to content

[ci] Add a third web Dart unit test shard (1/2)#12138

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
stuartmorgan-g:ci-web-shard-adjustment
Jul 8, 2026
Merged

[ci] Add a third web Dart unit test shard (1/2)#12138
auto-submit[bot] merged 1 commit into
flutter:mainfrom
stuartmorgan-g:ci-web-shard-adjustment

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

The web Dart unit tests are currently some of our slowest tests, and shard 2 is on the brink of hitting the 60 minute timeout. This is the first half of the process of switching from 2 shards to three shards, adding the new tasks in bringup mode but not yet changing the existing shards. Once this lands and propagates, a second PR will switch to actually using three shards.

This brings us closer to our limit of 100 post-submit tasks for our wait-for-release action, but doesn't yet cross it (and we expect that limit to stop being an issue soon).

The web Dart unit tests are currently some of our slowest tests, and
shard 2 is on the brink of hitting the 60 minute timeout. This is the
first half of the process of switching from 2 shards to three shards,
adding the new tasks in bringup mode but not yet changing the existing
shards. Once this lands and propagates, a second PR will switch to
actually using three shards.

This brings us closer to our limit of 100 post-submit tasks for our
wait-for-release action, but doesn't yet cross it (and we expect that
limit to stop being an issue soon).
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CI configuration in .ci.yaml by adding a third shard (web_dart_unit_test_shard_3) for both the master and stable channels of the Linux web unit tests. It also adds a TODO comment regarding future adjustments to WebAssembly testing once WASM builds become the default on the stable channel. There are no review comments, and I have no feedback to provide.

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator Author

Interestingly the wasm variant of the web unit tests is twice as fast as the non-wasm version (the actual testing looks like it's more than twice as fast, but there's fixed overhead for things like setting up the bot and fetching all the deps for the packages).

Comment thread .ci.yaml
@@ -216,7 +217,20 @@ targets:
version_file: flutter_stable.version
package_sharding: "--shardIndex 1 --shardCount 2"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is shardCount? should it not go to 3 on the other shards? or are index and count just the same thing but off by 1?

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 8, 2026
@stuartmorgan-g

Copy link
Copy Markdown
Collaborator Author

Since the tree status is currently red because Linux_web web_dart_unit_test_shard_2 master flaked due to hitting the one hour timeout when it was almost finished running, I'm going to consider this PR part of fixing the tree and land it.

@stuartmorgan-g stuartmorgan-g added the emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. label Jul 8, 2026
@flutter-dashboard

Copy link
Copy Markdown

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@auto-submit auto-submit Bot merged commit b626386 into flutter:main Jul 8, 2026
87 of 88 checks passed
@stuartmorgan-g stuartmorgan-g deleted the ci-web-shard-adjustment branch July 8, 2026 19:37
Renzo-Olivares pushed a commit to mvincentong/flutter that referenced this pull request Jul 9, 2026
…r#189194)

flutter/packages@52d84d6...20928d5

2026-07-09 44525804+sailendrabathi@users.noreply.github.com
[video_player_android] Implement backBufferDurationMs in ExoPlayer
(flutter/packages#12124)
2026-07-09 bolling.ludwig@gmail.com [camera_platform_interface] Make
setJpegImageQuality default a no-op (flutter/packages#12123)
2026-07-09 36081049+anirudhsharma392@users.noreply.github.com
[local_auth] Clarify getAvailableBiometrics documentation regarding iOS
permissions (flutter/packages#11901)
2026-07-09 stuartmorgan@google.com [ci] Add a third web Dart unit test
shard (2/2) (flutter/packages#12150)
2026-07-08 stuartmorgan@google.com [ci] Add a third web Dart unit test
shard (1/2) (flutter/packages#12138)
2026-07-08 43054281+camsim99@users.noreply.github.com Add pre-commit
hook to verify static analysis passes & format is correct
(flutter/packages#11941)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants