[ci] Add a third web Dart unit test shard (2/2)#12150
Conversation
Takes the new shard out of bring-up, and adjusts the existing shards to expect three shards rather than two.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates .ci.yaml by increasing the shard count from 2 to 3 for the web_dart_unit_tests.yaml targets on both the master and stable channels. It also removes the bringup: true property from the web_dart_unit_test_shard_3 targets. No review comments were provided, and there is no additional feedback.
|
Hm, even with the extra sharding, shard 2 took 52 minutes on one of the runs, and 38 on the other. Looks like most of it was @Piinks @justinmc is it normal for material_ui and material_ui/example tests to take ~25 and ~15 minute respectively? Landing this since it'll help, but material_ui alone is already too long for reasonable size shard. |
stuartmorgan-g
added
autosubmit
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
…r#189194) flutter/packages@52d84d6...20928d5 2026-07-09 44525804+sailendrabathi@users.noreply.github.com [video_player_android] Implement backBufferDurationMs in ExoPlayer (flutter/packages#12124) 2026-07-09 bolling.ludwig@gmail.com [camera_platform_interface] Make setJpegImageQuality default a no-op (flutter/packages#12123) 2026-07-09 36081049+anirudhsharma392@users.noreply.github.com [local_auth] Clarify getAvailableBiometrics documentation regarding iOS permissions (flutter/packages#11901) 2026-07-09 stuartmorgan@google.com [ci] Add a third web Dart unit test shard (2/2) (flutter/packages#12150) 2026-07-08 stuartmorgan@google.com [ci] Add a third web Dart unit test shard (1/2) (flutter/packages#12138) 2026-07-08 43054281+camsim99@users.noreply.github.com Add pre-commit hook to verify static analysis passes & format is correct (flutter/packages#11941) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Wow that that does not sound right. Material tests and Material API tests do not run in an isolated shard in flutter/flutter, but I looked into a couple runs in several PRs today and it looks like the material library typically tests out in under 5 minutes, and the API docs in about a minute and half, so.. something definitely smells here. @stuartmorgan-g did you open an issue for this? I take can it up and track it down. |
|
Oof, actually the web shards are different. Material tests along with other libraries are spread across 8 web shards. I forgot the web unit tests are sooo much slower. |
3 participants
Takes the new shard out of bring-up, and adjusts the existing shards to expect three shards rather than two.