Skip to content

[packages] Migrate all iOS example apps in flutter/packages to UIScene#12182

Merged
auto-submit[bot] merged 31 commits into
flutter:mainfrom
Zubii12:issue-188521-migrate-ios-examples-to-uiscene
Jul 24, 2026
Merged

[packages] Migrate all iOS example apps in flutter/packages to UIScene#12182
auto-submit[bot] merged 31 commits into
flutter:mainfrom
Zubii12:issue-188521-migrate-ios-examples-to-uiscene

Conversation

@Zubii12

@Zubii12 Zubii12 commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Migrate all iOS example apps in flutter/packages to UIScene lifecycle

Fixes flutter/flutter#188521

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the iOS examples of multiple packages to use UIScene and FlutterImplicitEngineDelegate, updating their AppDelegate and Info.plist configurations and bumping package versions. Review feedback highlights that the <key>UIApplicationSceneManifest</key> is missing before the <dict> element in the Info.plist files for extension_google_sign_in_as_googleapis_auth, file_selector, and file_selector_ios, which results in malformed plist files. Additionally, the Google Maps API key initialization was accidentally removed from the AppDelegate.swift of the google_maps_flutter example and needs to be restored.

Comment thread packages/file_selector/file_selector/example/ios/Runner/Info.plist
@Zubii12
Zubii12 force-pushed the issue-188521-migrate-ios-examples-to-uiscene branch from fb16569 to 183188c Compare July 23, 2026 20:32
@Zubii12

Zubii12 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

@Zubii12 This test failed. could you take a look? Thanks!

/Volumes/Work/s/w/ir/x/w/packages/packages/image_picker/image_picker_ios/example/ios/RunnerTests/ImagePickerPluginTests.m:371: error: -[ImagePickerPluginTests testCameraPickerInteractionBlockerWindowIsAddedAndRemoved] : ((window.isKeyWindow) is true) failed Test Case '-[ImagePickerPluginTests testCameraPickerInteractionBlockerWindowIsAddedAndRemoved]' failed (0.718 seconds).

@hellohuanlin Added a fix, please check.

@hellohuanlin hellohuanlin added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Jul 23, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 23, 2026
@auto-submit

auto-submit Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12182, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Jul 23, 2026
@hellohuanlin hellohuanlin added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Jul 23, 2026
@auto-submit

auto-submit Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12182, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 23, 2026
@LouiseHsu

Copy link
Copy Markdown
Contributor

I think this PR is missing changelog updates

  packages/animations:
    Missing CHANGELOG change
  packages/camera/camera:
    Missing CHANGELOG change
  packages/extension_google_sign_in_as_googleapis_auth:
    Missing CHANGELOG change
  packages/file_selector/file_selector:
    Missing CHANGELOG change
  packages/go_router:
    Missing CHANGELOG change
  packages/google_fonts:
    Missing CHANGELOG change
  packages/google_maps_flutter/google_maps_flutter:
    Missing CHANGELOG change
  packages/google_sign_in/google_sign_in:
    Missing CHANGELOG change
  packages/image_picker/image_picker:
    Missing CHANGELOG change
  packages/in_app_purchase/in_app_purchase:
    Missing CHANGELOG change
  packages/interactive_media_ads:
    Missing CHANGELOG change
  packages/local_auth/local_auth:
    Missing CHANGELOG change
  packages/path_provider/path_provider:
    Missing CHANGELOG change
  packages/pigeon:
    Missing CHANGELOG change
  packages/pointer_interceptor/pointer_interceptor:
    Missing CHANGELOG change
  packages/quick_actions/quick_actions:
    Missing CHANGELOG change
  packages/rfw:
    Missing CHANGELOG change
  packages/shared_preferences/shared_preferences:
    Missing CHANGELOG change
  packages/two_dimensional_scrollables:
    Missing CHANGELOG change
  packages/url_launcher/url_launcher:
    Missing CHANGELOG change
  packages/video_player/video_player:
    Missing CHANGELOG change
  packages/webview_flutter/webview_flutter:
    Missing CHANGELOG change

@Zubii12

Zubii12 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

@LouiseHsu Stuart Morgan said

These changes only affect unpublished parts of the examples, and so fall under one of our documented exceptions to versioning; these should not have version bumps.

#12182 (comment)

@stuartmorgan-g stuartmorgan-g added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jul 24, 2026
@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Jul 24, 2026
@stuartmorgan-g stuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Jul 24, 2026
@auto-submit
auto-submit Bot merged commit 6969329 into flutter:main Jul 24, 2026
13 checks passed
pull Bot pushed a commit to edisplay/flutter that referenced this pull request Jul 24, 2026
…er#189983)

flutter/packages@8260a1e...6969329

2026-07-24 ionutzubascu@yahoo.com [packages] Migrate all iOS example
apps in flutter/packages to UIScene (flutter/packages#12182)
2026-07-23 absarhshah@gmail.com [in_app_purchase] Fixes StoreKit 2 date
format does not match in_app_… (flutter/packages#11717)
2026-07-23 269567208+reidbaker-agent@users.noreply.github.com [packages]
Add changelog style references to AGENTS.md (flutter/packages#12277)
2026-07-23 ntosarno11@gmail.com [file_selector_android] Surface
file-copy failures to Dart instead of crashing (flutter/packages#12107)
2026-07-23 puneetkukreja98@gmail.com [google_maps_flutter] Add support
for mapType, fullscreen, and Street View controls on web
(flutter/packages#11955)
2026-07-22 engine-flutter-autoroll@skia.org Manual roll Flutter (stable)
from ee80f08 to 84fc5cb (5 revisions) (flutter/packages#12273)
2026-07-22 50643541+Mairramer@users.noreply.github.com
[camera_avfoundation] Move camera_avfoundation to Darwin
(flutter/packages#11847)
2026-07-22 engine-flutter-autoroll@skia.org Roll Flutter from
1ac2e82 to 2a2a79d (22 revisions) (flutter/packages#12272)
2026-07-22 puneetkukreja98@gmail.com [google_maps_flutter_web]: Adds
support for mapTypeControlEnabled, fullscreenControlEnabled, and
streetViewControlEnabled. (flutter/packages#12254)
2026-07-21 jmccandless@google.com [material_ui] Prerelease setup
(flutter/packages#12258)
2026-07-21 kienhantrung@gmail.com [go_router_builder] Allow users to
specify onExit as optional (flutter/packages#11151)
2026-07-21 fluttergithubbot@gmail.com Sync release-cupertino_ui-0.0.2 to
main (flutter/packages#12265)
2026-07-21 tarrinneal@gmail.com [pigeon] add support for top level
consts (flutter/packages#12032)
2026-07-21 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.activity:activity from 1.12.4 to 1.13.0 in
/packages/image_picker/image_picker_android/android
(flutter/packages#11253)
2026-07-21 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump cameraxVersion from 1.6.0 to 1.6.1 in
/packages/camera/camera_android_camerax/android (flutter/packages#11862)
2026-07-21 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump com.google.guava:guava from 33.5.0-android to
33.6.0-android in /packages/espresso/android (flutter/packages#11864)
2026-07-21 stuartmorgan@google.com [tool] Rename batch change override
label (flutter/packages#12263)
2026-07-21 jmccandless@google.com [cupertino_ui] Bump minor to get to
0.0.2, not patch (flutter/packages#12260)
2026-07-21 stuartmorgan@google.com [tool] Support pre-1.0 versions in
batch releases (flutter/packages#12257)
2026-07-21 jmccandless@google.com [material_ui] Remove manual version
changes (flutter/packages#12253)
2026-07-21 engine-flutter-autoroll@skia.org Roll Flutter from
cab057d to 1ac2e82 (23 revisions) (flutter/packages#12256)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UIScene] Migrate all iOS example apps in flutter/packages to UIScene lifecycle

5 participants