[tool] Rename batch change override label#12263
Merged
auto-submit[bot] merged 1 commit intoJul 21, 2026
Merged
Conversation
(again) This was given a more descriptive lbale in flutter#11835, but it appears based on failures when attempting to generate the PR that there is an undocumented length limit of 50 characters for label names, and `override: skip-batch-release-repo-check-` uses 40 of them, which causes problems when adding the package name. This renames to `override: batch-`, which is less descriptive, but should work around the length limit. Longer term, we may need to revisit having the package name in the label to avoid edge case issues with long package names.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the validator and associated tests to replace the override label 'override: skip-batch-release-repo-check-' with 'override: batch-'. Feedback on this change notes that the new label format may still exceed GitHub's 50-character limit for packages with long names, and suggests considering a shorter prefix or a generic label to prevent potential issues.
| // checks. | ||
| final bool shouldSkipBatchReleaseRepoCheck = _prLabels.contains( | ||
| 'override: skip-batch-release-repo-check-${pubspec.name}', | ||
| 'override: batch-${pubspec.name}', |
Contributor
There was a problem hiding this comment.
While renaming the label to override: batch-${pubspec.name} reduces the length, it may still exceed GitHub's 50-character label limit for packages with long names.
For example:
interactive_media_ads_platform_interface(40 chars) +override: batch-(16 chars) = 56 characters.google_maps_flutter_platform_interface(38 chars) +override: batch-(16 chars) = 54 characters.shared_preferences_platform_interface(37 chars) +override: batch-(16 chars) = 53 characters.
Consider using a shorter prefix (e.g., batch-${pubspec.name}) or a generic label like override: batch-release that applies to all packages in the PR to avoid hitting this limit.
Collaborator
Author
There was a problem hiding this comment.
For posterity: we can't remove override: without changing Cocoon, because there is Cocoon-level plumbing that carries over just override: * labels to a context where the CI tooling can see them.
Contributor
There was a problem hiding this comment.
You could also truncate the package name to the first 44 characters and hope we never end up with a collision.
Collaborator
Author
There was a problem hiding this comment.
I think if we have length issues again in practice we should probably just switch to a single static label rather than a per-package label. Things would have to go pretty seriously wrong for changes to be happening in the wrong package, and I would think the human review step would catch that.
justinmc
approved these changes
Jul 21, 2026
| // checks. | ||
| final bool shouldSkipBatchReleaseRepoCheck = _prLabels.contains( | ||
| 'override: skip-batch-release-repo-check-${pubspec.name}', | ||
| 'override: batch-${pubspec.name}', |
Contributor
There was a problem hiding this comment.
You could also truncate the package name to the first 44 characters and hope we never end up with a collision.
justinmc
added
the
autosubmit
This was referenced Jul 22, 2026
Zubii12
pushed a commit
to Zubii12/packages
that referenced
this pull request
Jul 23, 2026
(again) This was given a more descriptive lbale in flutter#11835, but it appears based on failures when attempting to generate the PR that there is an undocumented length limit of 50 characters for label names, and `override: skip-batch-release-repo-check-` uses 40 of them, which causes problems when adding the package name. This renames to `override: batch-`, which is less descriptive, but should work around the length limit. Longer term, we may need to revisit having the package name in the label to avoid edge case issues with long package names.
pull Bot
pushed a commit
to edisplay/flutter
that referenced
this pull request
Jul 24, 2026
…er#189983) flutter/packages@8260a1e...6969329 2026-07-24 ionutzubascu@yahoo.com [packages] Migrate all iOS example apps in flutter/packages to UIScene (flutter/packages#12182) 2026-07-23 absarhshah@gmail.com [in_app_purchase] Fixes StoreKit 2 date format does not match in_app_… (flutter/packages#11717) 2026-07-23 269567208+reidbaker-agent@users.noreply.github.com [packages] Add changelog style references to AGENTS.md (flutter/packages#12277) 2026-07-23 ntosarno11@gmail.com [file_selector_android] Surface file-copy failures to Dart instead of crashing (flutter/packages#12107) 2026-07-23 puneetkukreja98@gmail.com [google_maps_flutter] Add support for mapType, fullscreen, and Street View controls on web (flutter/packages#11955) 2026-07-22 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from ee80f08 to 84fc5cb (5 revisions) (flutter/packages#12273) 2026-07-22 50643541+Mairramer@users.noreply.github.com [camera_avfoundation] Move camera_avfoundation to Darwin (flutter/packages#11847) 2026-07-22 engine-flutter-autoroll@skia.org Roll Flutter from 1ac2e82 to 2a2a79d (22 revisions) (flutter/packages#12272) 2026-07-22 puneetkukreja98@gmail.com [google_maps_flutter_web]: Adds support for mapTypeControlEnabled, fullscreenControlEnabled, and streetViewControlEnabled. (flutter/packages#12254) 2026-07-21 jmccandless@google.com [material_ui] Prerelease setup (flutter/packages#12258) 2026-07-21 kienhantrung@gmail.com [go_router_builder] Allow users to specify onExit as optional (flutter/packages#11151) 2026-07-21 fluttergithubbot@gmail.com Sync release-cupertino_ui-0.0.2 to main (flutter/packages#12265) 2026-07-21 tarrinneal@gmail.com [pigeon] add support for top level consts (flutter/packages#12032) 2026-07-21 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.activity:activity from 1.12.4 to 1.13.0 in /packages/image_picker/image_picker_android/android (flutter/packages#11253) 2026-07-21 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump cameraxVersion from 1.6.0 to 1.6.1 in /packages/camera/camera_android_camerax/android (flutter/packages#11862) 2026-07-21 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.guava:guava from 33.5.0-android to 33.6.0-android in /packages/espresso/android (flutter/packages#11864) 2026-07-21 stuartmorgan@google.com [tool] Rename batch change override label (flutter/packages#12263) 2026-07-21 jmccandless@google.com [cupertino_ui] Bump minor to get to 0.0.2, not patch (flutter/packages#12260) 2026-07-21 stuartmorgan@google.com [tool] Support pre-1.0 versions in batch releases (flutter/packages#12257) 2026-07-21 jmccandless@google.com [material_ui] Remove manual version changes (flutter/packages#12253) 2026-07-21 engine-flutter-autoroll@skia.org Roll Flutter from cab057d to 1ac2e82 (23 revisions) (flutter/packages#12256) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(again)
This was given a more descriptive lbale in
#11835, but it appears based on failures when attempting to generate the PR that there is an undocumented length limit of 50 characters for label names, and
override: skip-batch-release-repo-check-uses 40 of them, which causes problems when adding the package name.This renames to
override: batch-, which is less descriptive, but should work around the length limit.Longer term, we may need to revisit having the package name in the label to avoid edge case issues with long package names.