[pigeon] Clean up legacy registrant code - #12205
Conversation
Now that the new APIs are available on stable, remove the view controller subclass workaround and use the standard scene-friendly registration system for channel code.
stuartmorgan-g
added
override: no changelog needed
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
You'll want to apply these changes to your new example copy in your PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the iOS runner example in Pigeon to adopt FlutterImplicitEngineDelegate on AppDelegate instead of using a custom ExampleViewController subclass. It also updates the storyboard to use FlutterViewController directly. The review feedback points out an unused controller variable in AppDelegate.swift that can be safely removed.
stuartmorgan-g
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/packages/12205, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
the
autosubmit
…er#190216) flutter/packages@3e63635...dd11626 2026-07-29 stuartmorgan@google.com [pigeon] Clean up legacy registrant code (flutter/packages#12205) 2026-07-29 me@davidmiguel.com [go_router] Add BlockedInitialNavigationException for blocked initial deep links (flutter/packages#12213) 2026-07-28 stuartmorgan@google.com [file_selector] Switch to Swift Testing (flutter/packages#12235) 2026-07-28 269567208+reidbaker-agent@users.noreply.github.com Exempt evals directories from version checks (flutter/packages#12299) 2026-07-28 dkwingsmt@users.noreply.github.com [material_ui, cupertino_ui] Migrate macros that contain `@tool` (flutter/packages#12271) 2026-07-28 katelovett@google.com [material_ui, cupertino_ui] Fix API doc references (flutter/packages#12274) 2026-07-28 43054281+camsim99@users.noreply.github.com [camera_android_camerax] Delete `GeneratedCameraxLibrary.java` (flutter/packages#12294) 2026-07-28 engine-flutter-autoroll@skia.org Roll Flutter from 9988960 to 0f02463 (16 revisions) (flutter/packages#12300) 2026-07-28 developeryusuf@icloud.com [vector_graphics_compiler] Ignore unrecognized font-weight values (flutter/packages#12199) 2026-07-28 stuartmorgan@google.com [tool] Support promoting to 1.0 in batch releases (flutter/packages#12262) 2026-07-28 1063596+reidbaker@users.noreply.github.com ci: Fix Zizmor github-env failure in install_flutter action (flutter/packages#12298) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Now that the new APIs are available on stable, remove the view controller subclass workaround and use the standard scene-friendly registration system for channel code.