Skip to content

[camera_android_camerax] Delete GeneratedCameraxLibrary.java - #12294

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
camsim99:camx_delgen
Jul 28, 2026
Merged

[camera_android_camerax] Delete GeneratedCameraxLibrary.java#12294
auto-submit[bot] merged 1 commit into
flutter:mainfrom
camsim99:camx_delgen

Conversation

@camsim99

@camsim99 camsim99 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Deletes GeneratedCameraxLibrary.java which is the pre-#8618 (migration to ProxyApis) pigeon code that the plugin used. It appears to no longer be used.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes an unused ArgumentCaptor from SystemServicesTest.java in the Android camera package. There are no review comments, and I have no feedback to provide.

@camsim99

Copy link
Copy Markdown
Contributor Author

This is test exempt because it only removes dead code.

@camsim99 camsim99 added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Jul 27, 2026
@camsim99
camsim99 requested a review from bparrishMines July 27, 2026 18:42

@bparrishMines bparrishMines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2026
@auto-submit
auto-submit Bot merged commit 32bb9bb into flutter:main Jul 28, 2026
12 checks passed
navaronbracke pushed a commit to navaronbracke/flutter that referenced this pull request Jul 29, 2026
…er#190216)

flutter/packages@3e63635...dd11626

2026-07-29 stuartmorgan@google.com [pigeon] Clean up legacy registrant
code (flutter/packages#12205)
2026-07-29 me@davidmiguel.com [go_router] Add
BlockedInitialNavigationException for blocked initial deep links
(flutter/packages#12213)
2026-07-28 stuartmorgan@google.com [file_selector] Switch to Swift
Testing (flutter/packages#12235)
2026-07-28 269567208+reidbaker-agent@users.noreply.github.com Exempt
evals directories from version checks (flutter/packages#12299)
2026-07-28 dkwingsmt@users.noreply.github.com [material_ui,
cupertino_ui] Migrate macros that contain `@tool`
(flutter/packages#12271)
2026-07-28 katelovett@google.com [material_ui, cupertino_ui] Fix API doc
references (flutter/packages#12274)
2026-07-28 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Delete `GeneratedCameraxLibrary.java`
(flutter/packages#12294)
2026-07-28 engine-flutter-autoroll@skia.org Roll Flutter from
9988960 to 0f02463 (16 revisions) (flutter/packages#12300)
2026-07-28 developeryusuf@icloud.com [vector_graphics_compiler] Ignore
unrecognized font-weight values (flutter/packages#12199)
2026-07-28 stuartmorgan@google.com [tool] Support promoting to 1.0 in
batch releases (flutter/packages#12262)
2026-07-28 1063596+reidbaker@users.noreply.github.com ci: Fix Zizmor
github-env failure in install_flutter action (flutter/packages#12298)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: camera platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants