Skip to content

[camera_web] Remove invalid @JS annotation on extension type constructors #12384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 2 commits into from
Aug 6, 2026
+5 −3
Merged

[camera_web] Remove invalid @JS annotation on extension type constructors #12384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a80b73
[camera_web] Remove invalid @JS annotation on extension type construc…
mdebbar Aug 6, 2026
2aef969
Bump camera_web version to 0.3.5+5 and update CHANGELOG
mdebbar Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/camera/camera_web/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.3.5+5

* Removes invalid @JS annotation from extension type constructors.

## 0.3.5+4

* Fixes a `TypeError` in `availableCameras()` caused by browsers (e.g. Firefox) returning
Expand Down
2 changes: 0 additions & 2 deletions packages/camera/camera_web/lib/src/pkg_web_tweaks.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ extension NonStandardFieldsOnMediaTrackSettings on MediaTrackSettings {

/// Brought over from package:web 1.0.0
extension type WebTweakMediaSettingsRange._(JSObject _) implements JSObject {
@JS('MediaSettingsRange')
external factory WebTweakMediaSettingsRange({num max, num min, num step});

external double get max;
Expand All @@ -63,6 +62,5 @@ extension WebTweakMethodVersions on MediaStreamTrack {
/// Allows creating the MediaTrackConstraints that are needed.
/// Brought over from package:web 1.0.0
extension type WebTweakMediaTrackConstraints._(JSObject _) implements JSObject {
@JS('MediaTrackConstraints')
external factory WebTweakMediaTrackConstraints({JSAny zoom, ConstrainBoolean torch});
}
2 changes: 1 addition & 1 deletion packages/camera/camera_web/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: camera_web
description: A Flutter plugin for getting information about and controlling the camera on Web.
repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_web
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22
version: 0.3.5+4
version: 0.3.5+5

environment:
sdk: ^3.10.0
Expand Down
Loading