[camera_web] Remove invalid @JS annotation on extension type constructors - #12384
Merged
auto-submit[bot] merged 2 commits intoAug 6, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
Author
|
Not sure what's wrong with |
Collaborator
|
No clue I'm afraid; I don't know anything about the infrastructure for the new zizmor scans. (I triggered a re-run to see if that helps, since it looked like some internal server issue.) |
Contributor
Author
|
Github is having issues (https://www.githubstatus.com/) |
This was referenced Aug 7, 2026
Subhanshu20135
pushed a commit
to The-Developer-Diaries/flutter
that referenced
this pull request
Aug 7, 2026
…r#190719) flutter/packages@4e3f83d...fc22143 2026-08-07 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 058e0af to 6b182d2 (4 revisions) (flutter/packages#12394) 2026-08-07 269567208+reidbaker-agent@users.noreply.github.com [camera_android_camerax][tool] Migrate complexity checks to package:cognitive_complexity (flutter/packages#12356) 2026-08-06 mdebbar@google.com [camera_web] Remove invalid @js annotation on extension type constructors (flutter/packages#12384) 2026-08-06 tarrinneal@gmail.com [pigeon] add support for analyzer 13 and 14 (flutter/packages#12358) 2026-08-06 katelovett@google.com [cupertino_ui, material_ui] Fix bad doc references (flutter/packages#12381) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes invalid
@JS()annotations from extension type constructors inpackages/camera/camera_web.Fixes flutter/flutter#190355
Description
In newer Dart SDKs (following Dart SDK commit dart-lang/sdk@cecd7ec rolled into Flutter in PR flutter/flutter#190158), placing
@JS()annotations on extension type constructors has no effect and is now flagged as an error (invalid_js_annotation).Removing these annotations resolves the error without altering runtime behavior.