Skip to content

[material_ui] Remove no shuffle from text field tests - #12547

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
ValentinVignal:material-ui/test/remove-no-shuffle-from-text-field-tests
Sep 2, 2026
Merged

[material_ui] Remove no shuffle from text field tests#12547
auto-submit[bot] merged 1 commit into
flutter:mainfrom
ValentinVignal:material-ui/test/remove-no-shuffle-from-text-field-tests

Conversation

@ValentinVignal

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#85160

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 22, 2026
@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Aug 22, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'no-shuffle' tag and associated TODO comments from the test file packages/material_ui/test/text_field_test.dart. There are no review comments, so no feedback is provided.

@ValentinVignal

Copy link
Copy Markdown
Contributor Author

This doesn't need a pending changelog file since it only affects a test

@elliette elliette left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this clean up!

@ValentinVignal
ValentinVignal force-pushed the material-ui/test/remove-no-shuffle-from-text-field-tests branch from ba12904 to c8a2f5e Compare September 1, 2026 06:24
@elliette

elliette commented Sep 1, 2026

Copy link
Copy Markdown
Member

Web tests timed out (re-running)

@elliette

elliette commented Sep 1, 2026

Copy link
Copy Markdown
Member

[From triage] @ValentinVignal do you mind resolving the conflicts? Thank you!

# Conflicts:
#	packages/material_ui/test/text_field_test.dart
@ValentinVignal
ValentinVignal force-pushed the material-ui/test/remove-no-shuffle-from-text-field-tests branch from c8a2f5e to 59e9742 Compare September 2, 2026 06:07
@ValentinVignal

Copy link
Copy Markdown
Contributor Author

@elliette Conflicts are resolved :)

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for your contribution:)!

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 2, 2026
@auto-submit
auto-submit Bot merged commit 168575f into flutter:main Sep 2, 2026
13 checks passed
github-merge-queue Bot pushed a commit to flutter/flutter that referenced this pull request Sep 3, 2026
flutter/packages@18fe786...f9b3954

2026-09-03 ashutoshagarwal2014@gmail.com [image_picker] Fix android-16
not picking up file (flutter/packages#11320)
2026-09-02 jmccandless@google.com [material_ui] Migrate off of
flutter_test's find.byTooltip and on to the local findByTooltip
(flutter/packages#12492)
2026-09-02 32538273+ValentinVignal@users.noreply.github.com
[material_ui] Remove no shuffle from text field tests
(flutter/packages#12547)
2026-09-02 21270878+elliette@users.noreply.github.com Add Material style
variant enum (#12221) (flutter/packages#12717)
2026-09-02 brian.egan@verygood.ventures [go_router_builder] Report
duplicate route paths at build time (flutter/packages#12399)
2026-09-02 victor.orozco@cloudsufi.com [google_sign_in] PR 1/4
google_sign_in_ios SPM packaging (flutter/packages#12654)
2026-09-02 55357489+voledyaev@users.noreply.github.com
[video_player_android] Report display size for anamorphic video
(flutter/packages#12360)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants