Skip to content

[google_sign_in] PR 1/4 google_sign_in_ios SPM packaging - #12654

Merged
auto-submit[bot] merged 3 commits into
mainfrom
pr1/google-sign-in-ios-spm-packaging
Sep 2, 2026
Merged

[google_sign_in] PR 1/4 google_sign_in_ios SPM packaging#12654
auto-submit[bot] merged 3 commits into
mainfrom
pr1/google-sign-in-ios-spm-packaging

Conversation

@victogomez-cs

@victogomez-cs victogomez-cs commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Creates a Swift Package Manager target so later PRs can add Swift sources without mixing them into the Obj-C target. CocoaPods still builds both as one pod.

This is packaging-only: Obj-C sources move to google_sign_in_ios_objc, and a placeholder Swift target re-exports that module. Plugin behavior is unchanged.

Matches the Obj-C / Swift SPM split already used by video_player_avfoundation and in_app_purchase_storekit:

  • Package.swift: google_sign_in_ios depends on google_sign_in_ios_objc; only the Swift product is exported
  • CocoaPods: combined source_files glob plus Swift stdlib xcconfig
  • Header search path stays include/google_sign_in_ios so existing #import <google_sign_in_ios/...> keeps working
  • Tests: #if canImport(google_sign_in_ios_objc) for the Obj-C module

Bumps google_sign_in_ios to 6.3.2.

PR 1/4 of the Obj-C → Swift migration. Follows #12484 (coverage backfill). Part of flutter/flutter#119103

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@victogomez-cs victogomez-cs added the triage-ios Should be looked at in iOS triage label Aug 27, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 27, 2026
@google-cla

google-cla Bot commented Aug 27, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the google_sign_in_ios package to version 6.3.2, introducing a Swift Package Manager target for the Swift implementation. It splits the codebase into separate google_sign_in_ios (Swift) and google_sign_in_ios_objc (Objective-C) targets in Package.swift, while combining them in the Podspec for CocoaPods compatibility. Additionally, it updates Pigeon generation paths to output Objective-C files to the new google_sign_in_ios_objc directory and adds conditional imports in tests and a new placeholder file. There are no review comments, so no further feedback is provided.

@victogomez-cs
victogomez-cs force-pushed the pr1/google-sign-in-ios-spm-packaging branch from c2332fb to 2cf54ae Compare August 27, 2026 17:37
@LouiseHsu
LouiseHsu requested a review from hellohuanlin August 27, 2026 21:56
@victogomez-cs
victogomez-cs force-pushed the pr1/google-sign-in-ios-spm-packaging branch from 2cf54ae to b306c56 Compare August 28, 2026 17:22
@victogomez-cs victogomez-cs added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 2, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 2, 2026
@auto-submit

auto-submit Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages/12654, Failed to merge flutter/packages/12654 with Pull request flutter/packages/12654 could not be merged: Merging stacked PRs via this endpoint is not supported. Use the asynchronous merge endpoint instead..

The Obj-C target is still pulled in as a dependency of google_sign_in_ios, matching video_player_avfoundation and in_app_purchase_storekit.
@victogomez-cs
victogomez-cs force-pushed the pr1/google-sign-in-ios-spm-packaging branch from b306c56 to a6041e6 Compare September 2, 2026 18:43
@victogomez-cs victogomez-cs added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 2, 2026
@auto-submit
auto-submit Bot merged commit 4ca43c3 into main Sep 2, 2026
13 checks passed
@auto-submit
auto-submit Bot deleted the pr1/google-sign-in-ios-spm-packaging branch September 2, 2026 20:42
github-merge-queue Bot pushed a commit to flutter/flutter that referenced this pull request Sep 3, 2026
flutter/packages@18fe786...f9b3954

2026-09-03 ashutoshagarwal2014@gmail.com [image_picker] Fix android-16
not picking up file (flutter/packages#11320)
2026-09-02 jmccandless@google.com [material_ui] Migrate off of
flutter_test's find.byTooltip and on to the local findByTooltip
(flutter/packages#12492)
2026-09-02 32538273+ValentinVignal@users.noreply.github.com
[material_ui] Remove no shuffle from text field tests
(flutter/packages#12547)
2026-09-02 21270878+elliette@users.noreply.github.com Add Material style
variant enum (#12221) (flutter/packages#12717)
2026-09-02 brian.egan@verygood.ventures [go_router_builder] Report
duplicate route paths at build time (flutter/packages#12399)
2026-09-02 victor.orozco@cloudsufi.com [google_sign_in] PR 1/4
google_sign_in_ios SPM packaging (flutter/packages#12654)
2026-09-02 55357489+voledyaev@users.noreply.github.com
[video_player_android] Report display size for anamorphic video
(flutter/packages#12360)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: google_sign_in platform-ios platform-macos triage-ios Should be looked at in iOS triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants