Skip to content

feat: add Knative serving dependency and app service config structs#7161

Merged
AdilFayyaz merged 5 commits intov2from
adil/apps-knative-infra
Apr 7, 2026
Merged

feat: add Knative serving dependency and app service config structs#7161
AdilFayyaz merged 5 commits intov2from
adil/apps-knative-infra

Conversation

@AdilFayyaz
Copy link
Copy Markdown

@AdilFayyaz AdilFayyaz commented Apr 6, 2026

Why are the changes needed?

The App Service needs to manage Knative KService CRDs to deploy and stop long-running apps. This PR lays the foundational infrastructure — dependency, scheme registration, and config — that subsequent PRs will build on.

What changes were proposed in this pull request?

  • Add knative.dev/serving v0.40.2 (pinned to a version compatible with the repo's existing k8s.io v0.28.x constraints)
  • Add actions/k8s/app_scheme.go: InitAppScheme() registers KService, Route, Configuration, and Revision types into the client-go scheme so the K8s client can work with KService CRDs
  • Add AppConfig to actions/config: feature flag, KService namespace, and request timeout bounds
  • Add AppsConfig to runs/config: public URL pattern template and internal app service URL for the control-plane proxy
  • Moved the files in app/ to flytestdlib/ and respectively the call sites as well

How was this patch tested?

  • go build ./actions/... ./runs/... passes with no errors
  • go mod tidy is clean with no missing or unused dependencies
  • Existing packages that use golang-lru (upgraded v0.5.4 → v1.0.2 as a transitive side effect) were verified: go build
    ./flytestdlib/... ./flyteplugins/... passes — v1.x preserves the non-generic API used by this repo

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>
@AdilFayyaz AdilFayyaz self-assigned this Apr 6, 2026
@github-actions github-actions bot mentioned this pull request Apr 6, 2026
3 tasks
@AdilFayyaz AdilFayyaz requested a review from pingsutw April 6, 2026 22:37
Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>
Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>
Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>
Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>
@AdilFayyaz AdilFayyaz merged commit e0df138 into v2 Apr 7, 2026
17 checks passed
@AdilFayyaz AdilFayyaz deleted the adil/apps-knative-infra branch April 7, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants