feat: add AppK8sClient for KService lifecycle management#7166
Open
AdilFayyaz wants to merge 8 commits intov2from
Open
feat: add AppK8sClient for KService lifecycle management#7166AdilFayyaz wants to merge 8 commits intov2from
AdilFayyaz wants to merge 8 commits intov2from
Conversation
This was referenced Apr 7, 2026
Draft
ef9cf97 to
2e383a4
Compare
pingsutw
reviewed
Apr 8, 2026
app/internal/k8s/app_client.go
Outdated
| } | ||
|
|
||
| // Populate current replica count and K8s namespace metadata. | ||
| status.CurrentReplicas = uint32(len(ksvc.Status.Traffic)) |
Member
There was a problem hiding this comment.
I think we should get the replica from kservingv1.Revision
Author
There was a problem hiding this comment.
I can pull it from the latest revision, but would there ever be a case that we have multiple revisions running at the same time? Each would then have it's own active pods
Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>
Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>
Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>
13e45a2 to
dc89b35
Compare
Signed-off-by: M. Adil Fayyaz <62440954+AdilFayyaz@users.noreply.github.com>
3 tasks
3 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: #7161
Why are the changes needed?
The App Service needs a K8s client to manage the full lifecycle of Knative KService CRDs — the single source of truth for app spec and status. This PR lays the infrastructure foundation and implements the core client.
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main