Fix dangling UploadMetadata reference in local-run inputs comment - #7753
Open
EngHabu wants to merge 1 commit into
Open
Fix dangling UploadMetadata reference in local-run inputs comment#7753EngHabu wants to merge 1 commit into
EngHabu wants to merge 1 commit into
Conversation
CreateLocalRunRequest.offloaded_input_data still pointed at DataProxyService.UploadMetadata, which was removed in the same change that introduced the routed local-run data path. Point it at CreateUploadLocation instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJa4n1pjJUBVQbjeWCZJyQ Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the documentation comment for CreateLocalRunRequest.offloaded_input_data to reflect the current upload API after the removal of DataProxyService.UploadMetadata, keeping the proto and generated client bindings consistent.
Changes:
- Replace the stale
DataProxyService.UploadMetadatareference withDataProxyService.CreateUploadLocation. - Add routing context via
SelectClusterRequest.OPERATION_LOCAL_RUN_DATAin the comment. - Regenerate/update the corresponding Go and TypeScript generated files to match the proto comment.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| flyteidl2/workflow/local_run_service.proto | Updates the field comment to reference CreateUploadLocation and the local-run routing operation. |
| gen/go/flyteidl2/workflow/local_run_service.pb.go | Regenerates/updates the Go binding comment to match the proto. |
| gen/ts/flyteidl2/workflow/local_run_service_pb.ts | Regenerates/updates the TS binding comment to match the proto. |
Files not reviewed (1)
- gen/go/flyteidl2/workflow/local_run_service.pb.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateLocalRunRequest.offloaded_input_datastill documents its upload path asDataProxyService.UploadMetadata, but that RPC was removed in the same PR that introduced it (#7737 — local runs moved onto the existingCreateUploadLocationAPI, routed viaSelectClusterwithOPERATION_LOCAL_RUN_DATA).Comment-only change; regenerated.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VJa4n1pjJUBVQbjeWCZJyQ