App log lazy fetching - #7762
Merged
Merged
Conversation
pingsutw
reviewed
Aug 5, 2026
| // Which of the two backends a batch of lines was read from. Distinct from LogsSource, which | ||
| // selects what a request asks for; this reports what a response actually carries. | ||
| enum LogLineSource { | ||
| LOG_LINE_SOURCE_UNSPECIFIED = 0; |
Member
There was a problem hiding this comment.
Should we add a comment explaining that we use live logs by default and fall back to persisted logs if they’re not available?
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
AdilFayyaz
previously approved these changes
Aug 7, 2026
AdilFayyaz
left a comment
AdilFayyaz
left a comment
Contributor
There was a problem hiding this comment.
Just one comment, otherwise LGTM! 👍
| } | ||
|
|
||
| // Which backends to stream from. Defaults to LIVE_OR_PERSISTED. Use LIVE_ONLY to get the live | ||
| // tail without paying for a persisted-history scan, and re-request with LIVE_OR_PERSISTED when |
Contributor
There was a problem hiding this comment.
This comment is likely stale under the new semantics. To return history for a running app the request would be for PERSISTED_ONLY right?
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
katrogan
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Add a log source field so the UI can fetch live or live + persisted on it's own decision.
Why are the changes needed?
What changes were proposed in this pull request?
Proto changes
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Stack
If you do use
git townto manage PR Stacks, the stack relevant to this PRwill show below. Otherwise, you can ignore this section.
Docs link