Skip to content

feat: count dropped action subscriber updates - #7810

Open
Rohithmatham12 wants to merge 1 commit into
flyteorg:mainfrom
Rohithmatham12:codex/flyte-subscriber-drop-metrics
Open

feat: count dropped action subscriber updates#7810
Rohithmatham12 wants to merge 1 commit into
flyteorg:mainfrom
Rohithmatham12:codex/flyte-subscriber-drop-metrics

Conversation

@Rohithmatham12

Copy link
Copy Markdown

Summary

  • add a Prometheus counter for action subscriber updates dropped because a subscriber channel is full
  • initialize the counter from the ActionsClient metrics scope
  • keep direct test fixtures nil-safe and add regression coverage for the drop path

Fixes #7641.

Testing

  • GOCACHE=/private/tmp/flyte-go-cache GOMODCACHE=/private/tmp/flyte-go-mod-cache go test ./actions/k8s -run 'Test(SubscribeIsScopedByRun|UnsubscribeScopedByRun|NotifySubscribersCountsDroppedUpdates|NewActionsClient_RequiresPositiveRecordFilterSize)$'

@github-actions github-actions Bot added the flyte2 label Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Prometheus counter for dropped subscriber updates

1 participant