feat: confirm before signing out #minor - #937
Open
pingsutw wants to merge 1 commit into
Open
Conversation
Sign Out in the avatar menu navigated straight to Admin's /logout, so a stray click on a small menu item ended the session with no way back other than logging in again. Adds a confirmation dialog matching the existing "Authorization Required" panel, and extracts that panel's styled Dialog into a shared SessionDialog so both session modals stay in step. Signed-off-by: Kevin Su <pingsutw@apache.org>
ursucarina
approved these changes
Aug 4, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #937 +/- ##
==========================================
+ Coverage 54.62% 54.71% +0.09%
==========================================
Files 585 588 +3
Lines 15316 15413 +97
Branches 2801 2831 +30
==========================================
+ Hits 8366 8433 +67
- Misses 6950 6980 +30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pingsutw
added a commit
to unionai-oss/flyte2-ui
that referenced
this pull request
Aug 4, 2026
Sign out fired on the menu item itself, so a stray click on a small entry ended the session with no way back other than signing in again. Adds a confirmation dialog built from the same pieces as the session-expired panel, matching what v1 shows (flyteorg/flyteconsole#937). Signed-off-by: Kevin Su <pingsutw@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Sign Out in the avatar menu goes straight to Admin's
/logouton click. This puts a confirmation dialog in front of it, styled like the existing "Authorization Required" panel.Type
Are all requirements met?
Complete description
UserProfile's Sign Out was a<Button href={getLogoutUrl()}>inside a popover — a stray click on a small menu item ends the session, and the only way back is logging in again.SessionDialog— the styledDialogextracted out ofLoginPanel(centered logo, 448px paper, full-width stacked actions). No visual change to the login panel; it just imports the shell now, so the two session modals stay in step.SignOutPanel— logo, "Sign out of Flyte?", Sign Out (still just an anchor togetLogoutUrl(), so the logout flow itself is untouched) and Cancel. Strings go throughcreateLocalizedString, matching the rest of the nav bar.UserProfile— the menu item now opens the dialog. It renders outside thePopoverso closing the menu doesn't unmount it.Unit tests cover the closed state, the confirm link target, and Cancel firing
onCancel:Tracking Issue
NA
Follow-up issue
NA