Image build script flag and remove 2.7 from travis, bug for serialize - #106
Merged
Conversation
added 3 commits
May 4, 2020 15:08
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
- Coverage 81.93% 81.91% -0.03%
==========================================
Files 208 208
Lines 13377 13381 +4
Branches 1111 1113 +2
==========================================
Hits 10961 10961
- Misses 2151 2155 +4
Partials 265 265
Continue to review full report at Codecov.
|
wild-endeavor
changed the title
wild-endeavor
changed the title
katrogan
approved these changes
May 5, 2020
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
May 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Minor switch in
flytekit_build_image.shand removing python 2.7 tests. Minor bug fix.Type
Are all requirements met?
Complete description
Adding a switch to the image building script to not push even when a
REGISTRYsection is detected. Currently the behavior is that if aREGISTRYis present, it'll automatically be pushed. By not pushing users can build images locally, but still have the image tagged with the full namedocker.io/corp/myworkflow:<sha>Python 2.7 is no longer supported.
When the
-f/--folderoption is specified, only the Identifier file was being written there. We need to write both files there.Tracking Issue
No issue, can create one, but minor cleanup only.
Follow-up issue
NA