Add RemoteFileAccessProvider - #1649
Closed
pingsutw wants to merge 8 commits into
Closed
Conversation
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
requested review from
cosmicBboy,
eapolinario,
kumare3 and
wild-endeavor
as code owners
May 18, 2023 17:20
Codecov Report
@@ Coverage Diff @@
## master #1649 +/- ##
==========================================
+ Coverage 71.00% 71.02% +0.02%
==========================================
Files 336 336
Lines 30781 30781
Branches 5576 5575 -1
==========================================
+ Hits 21855 21862 +7
+ Misses 8379 8372 -7
Partials 547 547
|
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
wild-endeavor
approved these changes
May 24, 2023
pingsutw
marked this pull request as draft
May 24, 2023 21:49
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Currently, flytekit remote will try to use s3fs to upload data, but it should use data proxy instead.
RemoteFileAccessProvider allows flytekit remote to upload the data (structure dataset, flyte file, etc) to the s3.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
https://flyte-org.slack.com/archives/CP2HDHKE1/p1684272325647759
Follow-up issue
NA