Conversation
katrogan
requested review from
kumare3,
matthewphsmith and
wild-endeavor
as code owners
March 4, 2020 23:51
kumare3
approved these changes
Mar 4, 2020
Contributor
|
Can we add a unit test? |
Contributor
Author
|
@kumare3 unit tests are already updated |
|
Hi, I tested this and it's still not working, see my last comment on flyteorg/flyte#180. It looks like this https://github.com/lyft/flyteplugins/blob/master/go/tasks/pluginmachinery/flytek8s/container_helper.go#L22 never actually happens with the sidecar_task |
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
May 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flyteorg/flyte#180 so that the vanilla flytekit
gpu_request&gpu_limitattributes get respected in the primary sidecar container.For background, we replace GPU requests/limits with the nvidia/gpu resource name.
Capitalization doesn't affect pod spec unmarshaling (tested in flyteplugins)