Don't require std::locale in chrono.h when FMT_USE_LOCALE is 0 - #4921
Open
nebkat wants to merge 1 commit into
Open
Don't require std::locale in chrono.h when FMT_USE_LOCALE is 0#4921nebkat wants to merge 1 commit into
std::locale in chrono.h when FMT_USE_LOCALE is 0#4921nebkat wants to merge 1 commit into
Conversation
is_classic_ becomes a compile-time truth and format_localized a no-op, so the facet calls compile away and neither tm_writer nor get_locale holds a locale. Output is unchanged; an -Os test program loses all 16 of its std::locale and time_put symbols and 9576 bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_classic_becomes constexpr andformat_localizeda no-op, so the facet calls compile away and neithertm_writernorget_localeholds a locale. Output is unchanged; an -Os test program loses all 16 of itsstd::localeandtime_putsymbols and 9576 bytes.