Skip to content

Documentation assigns locale disabling to the wrong FMT_OPTIMIZE_SIZE level #4922

Description

@dajiaohuang

At main 6226bc70b8e15060a21a281c5ec5f4b91be8582f, the configuration table in doc/api.md says FMT_OPTIMIZE_SIZE=1 disables locale support.

However, base.h defaults FMT_USE_LOCALE to (FMT_OPTIMIZE_SIZE <= 1). The FMT_USE_LOCALE entry on the same documentation page also correctly gives the disabling threshold as > 1.

The size-optimization table should say that level 1 applies optimizations while retaining locale support by default, and that level 2 disables locale support by default. Users choosing level 1 alone currently get a different locale configuration from the one documented. No runtime behavior change is needed.

This concerns the wording added in 41326207, after the configuration documentation requested in #4549. The active #4921 changes chrono behavior when FMT_USE_LOCALE=0, not this configuration table.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions