Skip to content

Correct locale support in size optimization docs - #4923

Open
dajiaohuang wants to merge 1 commit into
fmtlib:mainfrom
dajiaohuang:docs/4922-optimize-size-locale
Open

Correct locale support in size optimization docs#4923
dajiaohuang wants to merge 1 commit into
fmtlib:mainfrom
dajiaohuang:docs/4922-optimize-size-locale

Conversation

@dajiaohuang

Copy link
Copy Markdown

Fixes #4922.

Move locale disabling from the level 1 description to level 2, matching the default FMT_USE_LOCALE definition in base.h and the existing macro documentation. No runtime behavior changes.

Validation:

  • MSVC compile-time probes for FMT_OPTIMIZE_SIZE=0/1/2 confirm default FMT_USE_LOCALE=1/1/0.
  • Built the patched MkDocs site with the pinned documentation requirements, Doxygen 1.18.0 and PYTHONUTF8=1; checked the rendered configuration table. One existing chrono-format-specifications anchor warning remains. Without Python UTF-8 mode, the existing C++ handler cannot read Doxygen's UTF-8 XML under Windows cp1252.
  • git diff --check passes.

@vitaut

vitaut commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

lint failures is unrelated (will go away on rebase)

@dajiaohuang
dajiaohuang force-pushed the docs/4922-optimize-size-locale branch from 37ca6a5 to 7d00593 Compare September 5, 2026 16:41
@dajiaohuang

Copy link
Copy Markdown
Author

Rebased onto upstream main at d90c336 (Apply cmake-format) in 7d00593. The failing cmake-format job was caused by the older merge base's CMakeLists.txt formatting; the PR remains a doc-only change. git diff --check origin/main...HEAD passes, and CI should rerun on the rebased head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation assigns locale disabling to the wrong FMT_OPTIMIZE_SIZE level

2 participants