chore: remove dead UI code - #166
Merged
Merged
Conversation
- Delete Sidebar.svelte (232 lines) — confirmed zero imports across codebase, TopBar handles all agent navigation - Remove unused onAgentSelect prop from TopBar — never passed by any parent
|
forkwright
pushed a commit
that referenced
this pull request
Feb 28, 2026
Remove unused Sidebar.svelte and dead onAgentSelect prop
forkwright
added a commit
that referenced
this pull request
Jul 2, 2026
Replaces the 45-minute full-build gate-attestation with the fleet reusable trailer-verify (pinned; theatron precedent #165/#166). Lane branches carry box-produced Gate-Passed trailers; the full gate runs on the dispatch box before push instead of duplicating in CI. Security checks unchanged. Refs #6339 Gate-Passed: kanon 0.1.5 +stages:fmt,check,clippy,nextest,lint sha:547488ed9aa8426b246cd47893c9432860c0b0b4
forkwright
added a commit
that referenced
this pull request
Jul 7, 2026
Replaces the 45-minute full-build gate-attestation with the fleet reusable trailer-verify (pinned; theatron precedent #165/#166). Lane branches carry box-produced Gate-Passed trailers; the full gate runs on the dispatch box before push instead of duplicating in CI. Security checks unchanged. Refs #6339 Gate-Passed: kanon 0.1.5 +stages:fmt,check,clippy,nextest,lint sha:547488ed9aa8426b246cd47893c9432860c0b0b4
forkwright
added a commit
that referenced
this pull request
Jul 8, 2026
The correct implementation of #6339 (supersedes closed #6362): swaps the 45-minute full-build gate-attestation for the fleet reusable trailer-verify, pinned to the same SHA theatron uses (precedent: theatron#165/#166 — verifies stamps in ~7s, handles dependabot actors). Lane branches already carry box-produced `Gate-Passed` trailers; the full gate runs on the dispatch box pre-push instead of duplicating in CI. Security workflows unchanged and still required. Merge note: the check context renames from `gate-attestation` to `gate / gate-attestation` — branch-protection required contexts get updated at merge time (same procedure as theatron#161). Refs #6339
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sidebar.svelte(232 lines): File existed but was never imported anywhere in the codebase. Confirmed withgrep -r "Sidebar" ui/src/— zero references. TopBar already handles all agent navigation and selection.onAgentSelectprop fromTopBar.svelte: Prop was declared and called insidehandleAgentClick, but no parent component ever passed it — alwaysundefined. Removed the dead optional-call.Test plan
cd ui && npm run build— no broken imports