fix(zetesis): harden indexer search (SSRF, redaction, body cap) + quick-xml advisories - #488
Merged
Merged
Conversation
…cap, tx) - #429: a cancelled HTTP fetch returns a distinct Cancelled error instead of ParseResponse, no longer degrading every in-flight indexer. - #430: fetch_xml enforces a configurable max_response_body_bytes cap (default 16 MiB) on attacker-controlled bodies. - #431: RateLimited honors Retry-After so back-off engages. - #432: upsert_indexer_categories runs its DELETE + INSERTs in one transaction. - #433: indexer API keys are redacted from logged URLs. - #434: torrent download URLs are SSRF-validated — http(s) only, host DNS-resolved and every resolved address rejected if private/loopback/ link-local/CGNAT; fail-closed on resolution failure. - #459: NewznabClient/TorznabClient HTTP status + auth-failure paths tested. - #460: zetesis repo.rs gains an in-memory-sqlite test module. - #467: archon wires the ByparrProxy Cloudflare bypass from config instead of hardwiring NoProxy. Also resolves two quick-xml advisories published 2026-07-02 (RUSTSEC-2026-0194 quadratic-attribute DoS, RUSTSEC-2026-0195 NsReader namespace DoS): bump the direct indexer-XML parser to quick-xml 0.41 and ignore the transitively-pinned 0.37 (feed-rs, librqbit-upnp) with review-by, derived across deny/audit/osv. Closes #429 Closes #430 Closes #431 Closes #432 Closes #433 Closes #434 Closes #459 Closes #460 Closes #467 Gate-Passed: kanon 0.1.5 +stages:fmt,check,clippy,nextest,lint sha:fb78c8d064530f3d0387a4a12fc6cc9cfd1a89ba
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #429, #430, #431, #432, #433, #434, #459, #460, #467.
Changes
validate_fetch_urlnow allows only http(s), DNS-resolves the host, and rejects if any resolved address is private/loopback/link-local/CGNAT/unspecified; fail-closed on resolution failure.fetch_xmlenforces a configurablemax_response_body_bytes(default 16 MiB).RateLimitedhonors Retry-After;upsert_indexer_categoriesruns in one transaction.NoProxy.Security advisories (published 2026-07-02)
Also resolves RUSTSEC-2026-0194 (quick-xml quadratic-attribute DoS) and RUSTSEC-2026-0195 (NsReader namespace-allocation DoS), which broke
main's Security workflow overnight. The direct indexer-XML parser is bumped to quick-xml 0.41 (fixed); the remaining 0.37.5 is transitively pinned byfeed-rsandlibrqbit-upnp(no upstream 0.41 yet) and is ignored with areview-by: 2026-10-01, derived acrossdeny.toml/.cargo/audit.toml/osv-scanner.tomlviakanon audit derive-ignores.Verification
kanon gate --fullgreen (fmt, check, advisory-parity, cargo-deny, clippy workspace, nextest, kanon lint).