fix(controlplane): declare eventTypeId path param on UpdateEventType#2728
Merged
Conversation
Speakeasy generation failed linting: PUT /event-types/{eventTypeId} did
not declare its path parameter. Add the missing swag @Param and
regenerate OpenAPI artifacts. Audited the full spec: no other operation
is missing path params.
Co-authored-by: Smart Mekiliuwa <mekilis@users.noreply.github.com>
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first Speakeasy generation run failed OpenAPI linting in both SDK repos with:
UpdateEventType's swag annotation declared the route with{eventTypeId}but no matching@Param. This adds the missing path parameter and regenerates the OpenAPI artifacts.Also audited the whole spec programmatically: this was the only operation missing a declared path parameter.
Note: Speakeasy's linter is stricter than the
openapi spec validateused in the convoy-side check (which passes both before and after), so this class of error only surfaces at generation time.After merge
Merging this changes
docs/v3/openapi3.*onmain, which auto-triggersspeakeasy-sdk.yml— no manual dispatch needed. Generation should proceed past linting in both SDK repos.Related: PDE-755 / follow-up to #2724