fix(controlplane): unblock first Speakeasy SDK generation#2729
Merged
Conversation
Python: Speakeasy rejects packageManager setuptools; use uv. JS: remove the deprecated hand-written HTTP client during bootstrap (persistentEdits would keep it and it fails compilation under the generated node16 tsconfig), keep Webhook importable via a minimal entrypoint, make the protected verify chain use explicit .js extensions (valid under both commonjs and node16), map .js imports back for ts-jest, and pin verify's runtime/dev deps in gen.yaml so the generated package.json keeps them. Verified: trimmed repo passes tsc and all 31 verify vector tests. Co-authored-by: Smart Mekiliuwa <mekilis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first auto-triggered generation (after #2728) failed differently in each SDK repo:
convoy-python —
gen.yamlrejected outright:Fixed:
packageManager: uv.convoy.js — generation succeeded but compilation failed:
persistentEditspreserves the old hand-written HTTP client (src/Api/**,client.ts,interfaces/**), and those files use extensionless relative imports that don't compile under Speakeasy's generatednode16tsconfig (TS2835×many).Fixed in the bootstrap overlay/script (the 2.x break, applied at bootstrap time instead of hoping the generation PR could do it):
src/Api,src/client.ts,src/interfaces,src/utils/helpers, old client tests)src/convoy.tsentrypoint keepsrequire('convoy.js').Webhookworking.js-extension imports — verified compiling under both the current commonjs tsconfig and node16jestconfig.jsongains amoduleNameMapperfor ts-jest and is now.genignore-protectedgen.yamladditionalDependencieskeepshttp-status+ jest toolchain once the generator ownspackage.jsonValidation
tsc --noEmitclean, all 31 verify vector tests pass.js-extension imports compile under bothmodule: commonjsandmodule: node16(tested both)After merge
Related: PDE-755 / follow-up to #2724, #2728