fix(settings): bind the dialog's renamed open model - #287
Merged
Conversation
frappe-ui's SettingsDialog declares its open state as a named model
(`defineModel('open')`) and no longer accepts a bare `modelValue`. The
rename landed in v1.0.0-beta.52; frappe#285 moved this app from beta.24 to
beta.53 and crossed it.
A bare `v-model` therefore writes to a prop nothing reads, and Vue does
not warn — so desktop settings simply stops opening. Bind the model it
actually declares.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Confidence Score: 5/5The PR appears safe to merge. The named Reviews (1): Last reviewed commit: "fix(settings): bind the dialog's renamed..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop settings doesn't open on
develop. Clicking My profile (or any settings entry) does nothing — no dialog, no error in the console.frappe-ui's
SettingsDialogrenamed its open state to a named model in v1.0.0-beta.52:defineModel<boolean>({ default: false })— plainmodelValuedefineModel<boolean>('open', …)#285moved this app from beta.24 to beta.53 and crossed that rename.SettingsModal.vuestill binds a barev-model, which now writes to a prop nothing reads. Vue doesn't warn on an unknown model, so it fails silently.One line:
v-model→v-model:open.DialogkeepsmodelValueas a legacy binding, so the ~15<Dialog v-model="open">call sites elsewhere are unaffected —SettingsDialogis the only component in the family that dropped the alias, and it's used once.