Skip to content

fix: pick correct name when creating user from RFQ (backport #55468)#55472

Merged
mihir-kandoi merged 1 commit into
version-16-hotfixfrom
mergify/bp/version-16-hotfix/pr-55468
Jun 1, 2026
Merged

fix: pick correct name when creating user from RFQ (backport #55468)#55472
mihir-kandoi merged 1 commit into
version-16-hotfixfrom
mergify/bp/version-16-hotfix/pr-55468

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Jun 1, 2026

fixes #54770


This is an automatic backport of pull request #55468 done by Mergify.

@github-actions github-actions Bot added the needs-tests This PR needs automated unit-tests. label Jun 1, 2026
@mihir-kandoi mihir-kandoi enabled auto-merge (squash) June 1, 2026 05:43
@mihir-kandoi mihir-kandoi merged commit fc842fb into version-16-hotfix Jun 1, 2026
18 checks passed
@mihir-kandoi mihir-kandoi deleted the mergify/bp/version-16-hotfix/pr-55468 branch June 1, 2026 05:58
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.81%. Comparing base (d82e03e) to head (8b0fa68).
⚠️ Report is 70 commits behind head on version-16-hotfix.

Files with missing lines Patch % Lines
...ype/request_for_quotation/request_for_quotation.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           version-16-hotfix   #55472      +/-   ##
=====================================================
- Coverage              79.83%   79.81%   -0.03%     
=====================================================
  Files                   1172     1172              
  Lines                 127187   127231      +44     
=====================================================
+ Hits                  101546   101551       +5     
- Misses                 25641    25680      +39     
Files with missing lines Coverage Δ
...ype/request_for_quotation/request_for_quotation.py 63.09% <50.00%> (-0.30%) ⬇️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

frappe-pr-bot pushed a commit that referenced this pull request Jun 2, 2026
# [16.21.0](v16.20.1...v16.21.0) (2026-06-02)

### Bug Fixes

* asset scrap flow related changes ([e3f03a2](e3f03a2))
* billing address does not belongs to the company error ([e1f29de](e1f29de))
* **book_appointment:** when scheduling is disabled, block API endpoints (backport [#55455](#55455)) ([#55457](#55457)) ([aa5dfde](aa5dfde))
* changes as per review ([8b1d981](8b1d981))
* check perm for account (backport [#55479](#55479)) ([#55483](#55483)) ([0c946f2](0c946f2))
* **custom_financial_template:** sum account closing balances across dimensions ([3359e20](3359e20))
* import DateTimeLikeObject ([d82e03e](d82e03e))
* **issue:** check permission before issue status modification (backport [#55458](#55458)) ([#55460](#55460)) ([7c5d617](7c5d617))
* item master list view UI cleanup ([2d554c0](2d554c0))
* **je:** preserve account on duplicate row when party row exists (backport [#55180](#55180)) ([#55512](#55512)) ([fe585dc](fe585dc))
* Make Distributed Discount Amount field read only ([29441b7](29441b7))
* **manufacturing:** allow to edit batch size while creating a work order (backport [#55058](#55058)) ([#55326](#55326)) ([ae92a82](ae92a82))
* material transfer in transit issue ([356bb78](356bb78))
* merge conflicts ([b74e365](b74e365))
* new bom version should not recalculate operations through routing (backport [#55370](#55370)) ([#55372](#55372)) ([933ac01](933ac01))
* over order allowance setting fix ([41b2de3](41b2de3))
* pick correct name when creating user from RFQ (backport [#55468](#55468)) ([#55472](#55472)) ([fc842fb](fc842fb))
* **pos:** escape html output in pos page templates (backport [#55527](#55527)) ([#55529](#55529)) ([224426e](224426e))
* **pos:** escape item data on pos item selector (backport [#55503](#55503)) ([#55508](#55508)) ([5393c93](5393c93))
* **pos:** preserve contacts and enforce permissions in set_customer_info (backport [#55463](#55463)) ([#55466](#55466)) ([ef2700b](ef2700b))
* **ppr:** make default_advance_account optional ([7a7cc31](7a7cc31))
* **quotation:** made customer contact column visible (backport [#55433](#55433)) ([#55435](#55435)) ([2feb8eb](2feb8eb))
* **regional:** Japanese CT Rate (backport [#54998](#54998)) ([#55438](#55438)) ([7426aaf](7426aaf))
* resolve conflict ([abe19e1](abe19e1))
* **selling:** handle None values while grouping opportunities by utm … (backport [#55300](#55300)) ([#55328](#55328)) ([198970c](198970c))
* set a fallback value if no fiscal year set ([1521410](1521410))
* stock reco for legacy serial nos ([67c922c](67c922c))
* **stock:** add warning message to notify the user to configure the inspection ([1679680](1679680))
* **stock:** allow to create quality inspection after purchase/delivery ([51a140a](51a140a))
* **stock:** change qb to qb get_query to fix filter issues (backport [#55443](#55443)) ([#55445](#55445)) ([277a072](277a072))
* **stock:** get_actual_qty during cancellations (backport [#55388](#55388)) ([#55392](#55392)) ([faa1573](faa1573))
* **tds:** treat NULL and empty-string tax_withholding_group as equivalent ([82e12d2](82e12d2))
* unable to submit subcontracted job card (backport [#55537](#55537)) ([#55540](#55540)) ([ceb1042](ceb1042))
* update default_advance_account type ([0bbc493](0bbc493))
* use fiscal year instead of calendar year in accounting dashboard number cards ([81d10d3](81d10d3))
* use get_query instead of get_all for data fetching ([7cbef15](7cbef15))
* **UX:** Move title field to More Info ([20592fc](20592fc))

### Features

* build and upload assets to GitHub Releases ([4c05ebc](4c05ebc))
* over order allowance setting ([08eaaa5](08eaaa5))
* **payment-entry:** warn user before cancelling reconciled payment entry ([61d6d2f](61d6d2f))
@frappe-pr-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 16.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-tests This PR needs automated unit-tests. released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants