Skip to content

fix: opening bal double counting in Process Period Closing Voucher (backport #55495)#55502

Merged
ruthra-kumar merged 4 commits into
version-16from
mergify/bp/version-16/pr-55495
Jun 1, 2026
Merged

fix: opening bal double counting in Process Period Closing Voucher (backport #55495)#55502
ruthra-kumar merged 4 commits into
version-16from
mergify/bp/version-16/pr-55495

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Jun 1, 2026

While closing period using the new controller (Process Period Closing Voucher), opening balances were being double counted.


This is an automatic backport of pull request #55495 done by Mergify.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

❌ Patch coverage is 98.68421% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.91%. Comparing base (cd7e1bb) to head (ce97a74).
⚠️ Report is 29 commits behind head on version-16.

Files with missing lines Patch % Lines
...ing_voucher/test_process_period_closing_voucher.py 98.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           version-16   #55502      +/-   ##
==============================================
+ Coverage       79.82%   79.91%   +0.08%     
==============================================
  Files            1172     1173       +1     
  Lines          127088   127164      +76     
==============================================
+ Hits           101451   101624     +173     
+ Misses          25637    25540      -97     
Files with missing lines Coverage Δ
..._closing_voucher/process_period_closing_voucher.py 39.74% <100.00%> (+39.74%) ⬆️
...ing_voucher/test_process_period_closing_voucher.py 98.66% <98.66%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ruthra-kumar ruthra-kumar merged commit 4af265c into version-16 Jun 1, 2026
28 of 29 checks passed
@ruthra-kumar ruthra-kumar deleted the mergify/bp/version-16/pr-55495 branch June 1, 2026 10:30
@frappe-pr-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 16.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants