Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

support SQLite for functional testing purposes #12

Merged
merged 1 commit into from
@bendavies

fixes #11

@fre5h
Owner

I will take a look later. Much much later. Because I'm Ukrainian and we have revolution right now. Sorry

@bendavies

No worries, take care!

@franz-josef-kaiser

Good luck with your revolution!

@sumardi

Wishing good luck & safety to you @fre5h for doing what we're too scared to do. Fight for you freedom!

@JamesDingle

All the best and please stay safe!

@mbert

Привіт із Гамбурга - ми з вами!

@tivnet

@fre5h Держитесь, Артем - мы с вами!

@ralphbean

@fre5h solidarity!

@EgorIgorevich

@fre5h Слава Україні!!!

@glaszig

on which side are you fighting? independence from the eu? best of luck then and be safe. if you win, come to germany and teach us how to be a sovereign, proud nation with self-confidence.

@rburhum

What is the ETA for the completion of the revolution?

@garyharan

Is there an issue for the revolution? Can we label it as a blocker?

@bogdan-kulynych

Слава Україні!

@kjw

@glaszig The 'euromaiden' protests are in favour of closer European integration. Their president is moving the country closer to Russia.

@fre5h
Owner

@glaszig Fighting for our rights. Against dictatorship of Yanukovych
@rburhum Don't know. Three people already dead. Can be anything, anywhere, anytime

@fre5h fre5h was assigned
@ahmetalpbalkan

Did you guys set up a daily scrum with the government? Please bring that up in the daily triage meeting because this revolution has exec visibility. :v:

@rburhum

@fre5h My best wishes to you. stay safe.

@malovanets

@kjw the proper word is "Euro maidan". "Maidan" means square.

@sasfeld

good luck! For the majority of Ukraine!

@seanhandley

Beware of :bomb: and best of luck refactoring the totalitarianism and corruption out of the Ukraine.

@diggler

Я з вами! Шкода нема більше що ми в діаспорі можем робити щоб помогти. Бажаю здоровя та щасливість.

@ziggamon

Just so you know, this post hit # 1 on Hacker news, with # 2 also being about Ukraine. The world is watching and supporting you. All the best, and be safe.

@pilgunboris

Героям слава!

@Ryel

Goodluck

@i1t2b3

Героям слава!

@mikebevz

Героям слава!

@gavrix

Stay safe. удачи!

@royskim

Good Luck!

@xslim

Пидтримка з Амстердаму!

@harmy

peace bro!

@dimsemenov

Героям слава!

@tommygairbnb

You got this! :+1:

@Yuripetusko

удачи вам там!

@sarcan

@fre5h solidarity from turkey and germany!

@giuseppeminnella

Good luck!

@zhuangya

take care!

@luruke

good luck!

@raw-raw

Be safe and good luck. ☮

@gersande

Bonne chance! Stay safe if you can!

@oobgam

Good luck!

@chdow

героям слава!

@opicron

The people speak!

@pfote

As a former east german i have a idea how that feels.
Good luck and take care!

@ryana

Yup. Literally the best comment on a social network I've ever seen. +1 #12 (comment)

@2rs2ts

free(ukraine);

@meltedice

Good luck!!

@appplemac

Героям Слава!

@aniketbhatnagar

Good luck!

@kronos

Свободу Украине! Ураааа!

@JackBracken

What a time to be alive.

@dreampuf

Good luck!

@ahromis

героям слава!

@muhammadghazali

Good luck :smiley:

@amatecha

"we have revolution right now" -- posted 1h after pull request was submitted hahah :laughing:

just to add, my family is from Ukraine and I think it's very sad what has been happening lately. Here's hoping things change for the better very promptly. Good luck @fre5h :)

@TobiasBohn

good luck!

@folone

Слава Украине!

@netoneko

Good luck!

@danielsand

all the best - stay safe and sound and show them that the people are still the ones who lead together the country !

@jakobhans

Best wishes and stay safe!

@octagonal

Please stay safe! We here in Western Europe wish Ukraine the best of luck.

@proullon

Take care ! And good luck

@BenjaminVanRyseghem

nothing more to say except people from every where are with you :+1:

@diofeher

Good luck in your revolution, stay safe! :)

@paulmillr

Слава Україні!

@wasabia

good luck

@jtrinklein

Best of luck!

@bergel

Good luck!

@panych

Слава Україні!

@iamwonder

Good luck!

@chaddjohnson

I've been to Kiev -- such a wonderful place! Ukrainians are extremely nice people. Russia can go to hell -- and so can the Ukrainian president, Yanukovych.

Fight for your rights and for those of generations to come. Be safe!!

@rafaelrinaldi

Go Ukraine :facepunch:

Cheers from Brazil.

@anygizer

:blue_heart: Let :star2: God lead us! :yellow_heart:

@TimothyKlim

Слава Україні! :v:

@M4ikT

Take care! :v:

@eugenesia

Wishing you all the best @fre5h, and stay safe! We just had a riot in Singapore and things got ugly really quickly. Hoping for a peaceful resolution! :+1:

@christianbundy

Revolution? Ship it. :shipit:

@GhostToast

Be safe and make change

@voxpelli

Wish you all the best in your fight for democracy! It's a fight we should all be part of and never forget

@jefmathiot

Hope you will soon be able to merge this PR... Take care

@EmptyStackExn

Best wishes from FR

@Rawry

Stay safe! Слава Україні!

@jchenry

Obviously, the revolution will not be televised. It will be pull requested.

@nishanthc

Good luck comrade!

@Anatolii

Героям слава!

@jamland

Слава Українi! Glory to Ukraine!

@aarongray

Godspeed! :v:

@gaearon

Good luck!

@kjavaherpour

Viva las revolution

@sheredom

Viva la revolution from Scotland - stay safe!

@Anatolii

After all your comments GitHub really needs to add "Like" option.
Thanks for your support! We appreciate this!

Слава Українi! Glory to Ukraine!

(went to debug government)

@voloshyn

героям слава!

@fx
fx commented

Good luck with that revolution! :)

@daryltucker

GL with that debug, @Anatolii

@YIvanchenko

Копенгаген с вами! :v:

@filiptepper

Wolna Ukraina! Our thoughts are with you.

@jessetaylor84

Solidarity! Many of us are watching and supporting you here in the US ... Stay strong and keep kicking fascist ass!

@bueltge

Best wishes and I fight for you in my mind. I'm East German and I understand the revolution.

@tuttleorbuttle

good luck and be safe.

but be careful not to help any fascists to power.

@shtumi

Харьков с вами!

@Stimpy777

Yeah Dr. Steelhammer is with you!

@nfx

don't get yourself injured! good luck!)

@sergey-shevchenko

Харьков и Гаага с вами! Только победа, ни шагу назад! По долгу работы пока приходится быть здесь.

@JohnMcLear

<3 Ukraine, good luck to you and your country.

@fdiasdev

all the best... good to see the dev community worring about that...

@hernanc

Stay strong!

@gesa

Wisconsin stands with the people of Ukraine!
SOLIDARITY

@lookitsatravis

Good luck, and godspeed!

@louis-paul

Good luck!

@lukaszwit

disable_functions=die

@mosinandrey

Запорожье едет в Киев!

@fre5h
Owner

Thanks to everybody. It is a pleasure to feel the support from you. We have only one way. Way to victory. Otherwise we all will be captured, repressed or killed.

P.S. This young Ukrainian patriot who struggled for freedom was killed by sniper. R.I.P.
Few days ago he was alive http://www.youtube.com/watch?v=CyFqqstK7e0
This morning he was dead http://www.youtube.com/watch?v=z_TZYrlxymY

@haraldschilly

Looking at the news, your revolution is a kinda much larger pull request for the government: :boom:

@kremlin-

good luck and stay safe friend

@eddotman

Good luck!

@lukkonior

Best!

@fre5h
Owner

Here is a link http://ukrstream.tv/ with two cameras. One on the battlefield and one on the Independence Square (Maidan).

Also some other links. Maybe in some countries they are blocked.
http://www.youtube.com/user/HromadskeTV?feature=watch
http://www.youtube.com/user/espresotv?feature=watch
http://spilno.tv/

Also you can search for hot news in twitter by tag #євромайдан

@szuliq

Powodzenia. удача.

@tyv

удачи, береги себя!

@visenger

Слава Украине! Я горжусь вами! Вы победите!

@tczepiel

Good luck!

@mikekotsch

Stay safe!

@istrasoft

Надеюсь что народ победит !

@whyleee

За свободное будущее!

@michaldudek

Good luck! This BC break is very welcome!

@neoascetic

Shit. I don't want to have comments like these on PRs to my repos while I stay here, in Russia...

@tomaszchabinka

Best luck from Poland!

@hubertlepicki

@neoascetic you'd have to do a revolution in Russia. You did once and it did turn out pretty bad for whole region (remember November 1917?). Better make your country more democratic with peaceful means.

@fre5h stay safe, stay in peace, hope your revolution will be successful and as peaceful as possible...

@neoascetic

Shit. 2017 is near...

@josephfoulds

I know you'll probably never read this but I'd like to add my personal support. I know we've never met, and I know you don't know me, but hopefully someone hundreds of miles away wishing you support will mean something personally to you.

Best of luck, my friend.

@redrory

Stay safe my friend.

@ChooJoy

Россия с Вами!
Только постарайтесь, выгнав бандитов, не отдать власть в руки другим бандитам!
Fix transparancy and make democracy!

@kindy

Good luck!!!
祝平安、好运,成功。 @fre5h

@1989car

Good luck and stay safe!
祝你好运,注意安全!

@ktorn

Good luck!

@lawrencejones

Good luck!

@mufid

Good luck! Hope the best for your country and this world!

@Miista

Good luck with the revolution. I wish for the best possible outcome.

@Martz

All the best

@gunnargrimsson

Our hearts are with you, stay safe and win!

http://www.youtube.com/watch?v=pXVlQTC2yB0

@MuyouSome

保重!

@5HT

Героям Слава!

@guotie

Good luck!!!
祝平安、好运,成功。 @fre5h

@furkanmustafa

No mercy for (self claimed) authorities, good luck!

@AstroProfundis

Good luck with your revolution!

@icyleaf

祝好运与成功!

@ethdemor

Good luck! :+1:

@dillonweip

好运平安!!!

@coosir

点赞 :+1:

@geekli

Good luck!!

@idao

程序员一生平安!

@venkatn93

Good luck!

@leondu

good luck!
好人一生平安!

@hzlzh

Sound and Safe~

@xuemengfei

Good luck with your revolution!
平安

@applesstt

Good luck!
新年快乐!

@Barbayar

stay safe, bro

@hak8or

I love how this is probably the most commented pull request for sqlite.

Good luck with the revolution!

@Liuchang0812

Good luck~~

@otiai10

お気をつけて

@tangzero

Boa sorte com a sua revolução!!!

@mopig

哇~

@dcosnet

i created a github account just to comment here.
dcos.net says good luck and long live freedom

@lwbjing

@fre5h 上天会眷顾程序员的。祝安。

@jcrubino

If you do step into the frey bring do not go without Maestro Davide Martello.

@shellcodecow

@fre5h Good luck! 祝你平安,

@wensonsmith

Good life of peace

好人一生平安

ชีวิตที่ดีของความสงบสุข

평화의 좋은 생활

Barış iyi bir hayat

Boa vida de paz

@rdalin82

Be safe. Happy Revolutioning!

@jianchen2580

Good Luck

@wtser

好人一生平安啊

@rubanm

Good luck! ⚡️

@chshouyu

挤一挤
虽然我不知道这是什么项目
虽然我不知道你们在说什么
但还是说两句吧

@wdd2007

程序员一生平安!

@devchenpy

Good luck!

@kovacs

Fork that government! Best of luck to you!

@JoyNeop

Good luck! Honor of you!

@raybest4u

Good luck. be safe.

@Ysudo

Goodluck!

@huweixuan

Goodluck!

@mleems

May the force be with you XD

@StrongSu

Good luck!

@dreamiurg

Героям Слава!

@lovedboy

@fre5h The best wish from China

@towserchen

god bless u

@lemonkoala

I'm a part of this. Good luck!

@afs2015

Good luck!

@yungookim

good luck!

@stormzhang

平安!

@tangramor

good luck! 祝一切平安!

@moonranger

Good luck!

@manageyp

Fight for freedom!

@Leslie2014

god bless you.

@xiaopeifenng

兄弟,good luck!

@chemdemo

Good luck!

@DNA

Слава Украине! Героям Слава!

Best wishes from Brazil, for you and your country! Keep safe, keep free! :)

@erikncsu

Keep fighting the good fight!

From Durham, NC

@kainwu

Oh God!!
Stay safe~~

@intrixs

Good luck!

@Archenoth

Good luck from Canada..!

Here's hoping for the best possible outcome.

@zorceta

Scary for us...anyway stay safe and come back!
Best luck!

@darthbinamira

Good luck!

@yangsibai

Fight for your freedom and good luck!

@chenshaoju

Good luck! :+1:

@aanbrn

Idiocracy!

@vrenna

Bonŝancon — mi deziras al vi la plej bona!

@chaimwang

Good luck!

@qianzhangsheng

Good luck!

@yangzhe1991

Good luck!

@purprin

Pray for you

@wxspll

Pray for you, from China!

@kurtqiao

good luck&wish the people all right

@yujingz

程序员一生平安,尽早平息暴动!

@todaylxp

my god!

@Tmeng

Hope you'll be all fine.

@cenphoenix

take care

@too

Ukraine, 加油

@vlsi1217

keep on fighting for freedom!

@xuqihua

为自由而战!@fre5h

@ghost

Срећно!

@OpenHero

Stay safe!Good luck!@fre5h

@FlashSoft

保重

@10iii

珍重!
Stay safe!

@Rothcold

Good luck. For freedom!

@iu2fish

Good luck!

@uspython

Fighting for freedom!
Stay safe bro!

@Follen

Take care bro.
保重!!

@mashuai

Good luck

@mysoko

Good luck!

@evan449

Good luck!

@qiaoxueshi

@fre5h Good luck, my friend!

@ciel-yu

@fre5h Be safe, may the force be with you.

@mingyun

good luck 与天朝同在

@ddmbr

打倒反动派!Good luck!

@irony

Lycka till! ;)

@nevercry

Good luck!

@zhen9ao

带上卡尔 @fre5h

@demon0925

Good luck!

@micarol

Best wishes to you.

@blimey74

saoirse le haghaidh an Úcráin

@Jcdroid

Be safe and good luck !
祝你平安与好运!

@phun-ky

Lykke til! Good luck!

Democracy by the people, for the people

@alextumarkin

Слава Україні!

@blag

Best of luck with the revolution! Don't settle for less than freedom!

@stephanerangaya

Good luck, I'll be glad to see Ukraine in the European Union. I wish you freedom, democracy, safety and peace.

@ssakal

Героям Слава!!! Смерть ворогам!!!

@maxim-styushin

posting in an epic thread

@littleyang

Good Luck!!!!
China Programmer Supported You!!!!!
祝愿楼主好运

@fre5h

@loxiran

good luck and take care!

@dkitipov

Bulgaria is with you, too!

@manjencic

Good luck! :fist:

@gisxing

Szabadság, Szerelem!
E kettő kell nekem
Szerelmemért föláldozom
Az életet,
Szabadságért föláldozom
Szerelmemet.

生命诚可贵,
爱情价更高;
若为自由故,
二者皆可抛。

@slafs

Good luck from Poland! And take care!

@tzzcl

@fre5h
Good Luck And Take Care!!!!
China Programmer Supported You!!!!!
祝愿楼主好运

@sunhr

Good Luck!!
Hope programmers could change the world...

@aristofun

Guys, all who wishes luck, "fight for freedom" and all that bullshit – most of you have absolutely no idea what's going on there (except the brainwashing your TV channels show you) and your comments look silly.

I'm really sorry for Ukraine, cause i have a lot of relatives there.

But the only my wish for normal people living there – fuck the revolution, fuck the government and make peace.

@croath

Take care, and good luck to you!

@lincolnlau

man, take care.

@simonmysun

Revolution? That's cool. Stay safe!

@tPl0ch

Good luck guys, but with this guy in your rows, the revolution is gonna be successful!

Klitschko in RAGE

Starface

@slafs

@aristofun If Poland fucked the revolution, as you suggest, we wouldn't be a free country right now.

@hennywei

good luck

@sioLabs

late but being a part of histry

@lxyxynt

Good luck>_<

@aristofun

@slafs but canada won russia in ice hockey couple of years ago

@itsNikolay

ljnkv8iayug
Good luck!

@Valve

Ukrainans and Russians are brothers, stop the madness!

@neemzy

@fre5h Good luck from France to you and your compatriots !

@folone

@Valve 75% of russians are more engaged with discussions of Ukraine's integration in Europe, than with Russia's integration in hell.

@kyliekarnage

Stay safe!

@Anlibraly

Good luck !!!

@yev

Слава Україні!

@TimothyKlim

@aristofun

fuck the revolution, fuck the government and make peace

pick one

@newwst

( translate.google from PRC/China)
Удачи вам :) Свободу Украине ! Слава Україні ! ми з вами !
保重 :) 自由必胜!我们永远与乌克兰朋友同在~~~
Stay safe :) God bless Ukrainians Freedom ! We are the world~~~
Liberté, égalité, fraternité!

@hustlzp

保重!(Good luck!)

@Edward-Bazko

Привіт з Амстердаму. Слава Україні!

@karol-f

Good luck!

@zorksylar

good luck, stay safe ! @fre5h

@alacaba

good luck comrade!

@alivelee

It's about time to fight for your freedom
Good Luck

@Jamesits

Good luck! Everything will be ok.

DBAL/Types/AbstractEnumType.php
@@ -61,6 +63,10 @@ function ($value) {
$this->getValues()
);
+ if ($platform instanceof SqlitePlatform) {
+ return 'TEXT CHECK(' . $fieldDeclaration['name'] . ' IN (' . implode(', ', $values) . '))';

It will be more readable:

$valuesString = implode(', ', $values);
return "TEXT CHECK({$fieldDeclaration['name']} IN ($valuesString))';

Good luck with the revolution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@hit9

Good luck!

DBAL/Types/AbstractEnumType.php
@@ -61,6 +63,10 @@ function ($value) {
$this->getValues()
);
+ if ($platform instanceof SqlitePlatform) {
+ return 'TEXT CHECK(' . $fieldDeclaration['name'] . ' IN (' . implode(', ', $values) . '))';
+ }
+
return 'ENUM(' . implode(', ', $values) . ')';

as in previous comment - also you can implode values before.

Good luck with the revolution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@Damngood

¡Hasta la Victoria Siempre!

@tomukas

Good luck from Lithuania.

@Winiex

Good luck buddy!

@FloEberle

@fre5h Good luck! :v:

@rmacnell

good luck!

@drgomesp

@fre5h Don't give up man! Brazil supports you!!!

@tchandy

Good luck from Brazil!

@maplebeats

@fre5h 加油!

@HALOSTAR

楼主保重~

@MrZoidberg

Good luck from Kharkov

@deanmongel

Good luck stay safe

@Gexos

@fre5h Stay strong my friend, fight for your freedom, solidarity from Hellas, soon very soon we'll be there too.
"Rise And Rise Again Until Lambs Become Lions"

@cloudmonkeypeng

Good luck! And be safe!

@benleb

Good luck from Germany!

@liuyix

Good luck and stay safe from China! @fre5h

@unidevel

祝你平安!Wish you safe and sound!

@Mparaiso

Bonne Chance! good luck!

@nanvel

Слава Україні!

@ZoomQuiet

Good Luck!
天朝人民仰慕ing...

@loliworld

Good Luck! Please be safe and sound!

@PeerXu

Take care of yourself!

@zwf

Good luck and take care.

@btspoony

Good luck from China. Owner好人一生平安!

@vitaminrad

Programmers all speak the same language of peace! Brother!

@albertodebortoli

Buona fortuna bro!

@wangeek

保重!

@mailworks

Good luck

@Jayin

Good luck! 保重!@fre5h

@freekode

In eventually justice should win

@scaret

Take care of yourself for the project -_-

@megaPUFF

good luck

@radicans

FYI: It probably cost you more time to actually comment on this pull request(multiple times) then it's to actually press a merge button..

@pank7

good luck

@Stumble

For love and peace.

@JadiysonTaki

Good luck and take care of yourself!

@sanmisanFan

Viel Glück und 兄弟好人一生平安……

@ribel

Героям Слава!

@huyinghuan

Good luck.

@pjq

Good luck, fight for your freedom

@SummerWish

Good luck!

@tru2dagame

Stay safe & Good Luck For freedom!
加油!
From China

@vuryleo

Good luck! For freedom!

@cactusthinking

Good luck and stay safe!
祝你好运,注意安全!

@tdoly

good luck ! @fre5h

@amcsi

Good luck!

@fonji

:+1: Good luck!

@kevincobain2000

:+1: Good luck. and yeah end the dictatorship. Hope ending dictatorship was as easy as applying a diff patch. Software is much easier to manage than real life.

@ninabyte

Stay safe!

@welsby

good luck hot-fixing democracy!

@an9ryfr09

God bless for you @fre5h

@cuter44

May you safety and finally complete the pull one day... ^ω^

@JoveYu

Good luck

@waveacme

Take care! Brother.

  • From China
@KendallPark

You got this bro. :punch:

@dinglioutlook

What can i say? Good luck man.

  • from China
@answer-huang

兄弟,保护好乌克兰妹子,我们马上就来!

@maximkott

Мы с Вами!

@orangle

好运。朋友。

@RickyLin

GOOD LUCK!!
Come back safely!!
A programmer from China is supporting you and your country!!

@PaulaRudy

Stay safe! You're in our thoughts here at r/ProgrammerHumor

@enroxorz

Good luck and stay safe and free

The world is behind you

@zerozeroone

祝平安!

@mjtorn

Good luck and stick it to the man!

@wangyingang

好运,保重!

@GYZHikari

好运!!记得回来改代码哟!

@CyberZHG

围观楼上

@Hezard

Слава Украине!

@folone

Героям Слава!

@nobodyiam

Good luck

@yaoazhen

Fighting!
Stay safe!
Good Luck!

@Pisces000221

Good luck
Remeber SQLite :)

@yipeipei

( ̄Д ̄)ノ Good luck to you

@dazzyd

Good luck

@SnowOnion

Wish you have a brave new world (ノ゚∀゚)ノ 为了美丽新世界

@BambooIV

GOODLUCK

@dlebedynskyi

Cлава Украине!

@VeleslaV

Героям Слава!

@jwalton

Good luck, sir.

@lyxsus

Удачи вам!

@jLouzado

Good luck and take care. Solidarity from India.

@blob0815

Good luck and stay safe!

@fatganz

Guys, this is revolutional pull request, isn't it? ) Героям Слава!
They will suck!

@SpearThruster

Go get em!

@poem

Good luck!

@nin-jin

Организуйте там технократию!)

@ToninoTarsi

take care!

@cdiscrete

God's in his heaven, All's right with the world.

@AnnJ

Американська діаспора бажає вам всього найкращого. Разом нас багато!

@xleft

change your country and change the world
向勇敢的人们致敬

@bademux

Направіць раз ды на заўсёды. Трымайцеся! :v:

@herrquark

I'm Ukrainian and I can't keep calm

@xizzhu

Go Ukraine! Support from a Chinese in Finland.

@satyadeepk

The whole world is with you. May the peace dawn.

Cheers from India!

@gavrix

Until you, @gekannt, give evidence about usa's money, please stop saying what you've been told on TV. Evidence!

@subdee

Καλή τύχη και κουράγιο!

@qapaul

Good Luck and God Bless your efforts!

@vanhalt

Best response EVAH! good luck!

@hoyang

Good Luck.
Cheers from China.

@antojoseph

Good Luck... Cheers from India :dancer:

@gaearon

@gekannt

fighting against government for USA's money.

I wouldn't hesitate taking money from any country to fight against the government that does this to its people:

http://www.youtube.com/watch?v=z0zD3pOG-Tk

@jvoisin

Good luck o/

@sdjnmxd

Don't give up!
别放弃!

@layerssss

I can feel your determination and courage. And save those comments from both-sides, I shall say, your government must have completely failed your people's trust. Every human wants to be peace, alive and safe. You must have your reasons to take so much courage and actions.

We'll keep our hearts with your struggle, and maybe SOMEDAY it will be OUR struggle, when we are also facing the same situation. The world is watching you. Above all, be safe and reasonable.

保重!

@mrseaman

Good Luck

@leonora

how's the revolution going

@szymonpt

Good luck!

@giang271291

This gotta be the hottest merge on github right now

@hanswolff

@fre5h I have a good feeling about your revolution. Good look!

@lgrote

Good luck!

@dajuris

@fre5h, good luck!

@ramonsmits

Vive L'Ukraine

@braginets

Dear colleagues from all of the world! - thank you for your support - it is more than important for us.
We were nearly thought that nobody noticed revolution in the middle of the Europe continent )
Freedom worth fighting for it.
best regards from Ukraine! Слава Україні!

@yzliao

Good luck!

@keithkiden

预祝革命成功。。。

@Cysioland

Good luck!

@regedarek

powodzenia!

@EugenMayer

Keep on!

@jchd

Fighting tyrany always brings tears, just as the relation of dead or wounded innocents currently covered by EU medias. Your karma is to fight beyond tears.
My French heart is all with all of you, sincerely.

@gennad

Удачи вам!

@darvin

Best wishes! Freedom for Ukraine!

@filipp

Good luck and be safe!

@m-khl

@fre5h no probs take your time. burn them all http://www.youtube.com/watch?v=cuO53xeZkm8

@sanzstez

Слава Україні!

@mourner

:heart: разом переможемо :)

@Shadark

Buena suerte!

@bezhermoso

@fre5h Good luck and stay safe!

@conanca

god bless you.

@DanielBlack

Good luck...

@phariel

Good luck, may the force be with you..

@inferjay

@fre5h Good luck!

@yingke

祝 平安!!

@fifsky

平安

@caicry

保护好自己 不要参加革命 把伟大的生命奉献给coding 世界..
please don't forget you neet to pull...

@easingz

Good luck!!!
程序员一生平安。

@yzliao

@caicry 你太凶残了。。

@TimePPT

Good luck!

@clausewitzer

gold bless you

@dianlujitao

Good luck!保重!

@IPL

Good Luck!

@ximu

GOOD LUCK!

@ghost

阳光总在风雨后,哥们加油!

@xiaoli-chen

Good luck and keep alive~

@shuhongwu

#祝平安#

@songyingxinok

平安

@0-14N

good luck

@simlegate

对于这种pull request~我想说你就直接merge了吧~

@EdisonY

luck

@alexzhcn

take care, 自由必胜

@hbbalfred

good luck

@Scuzzball

Wishing you luck from Michigan, US.

@worldask

good luck!

@buddyli

Fuck the gorvenment!

@alexzhuustc

顶,support!

@echodjb

Good Luck !

@rickdgit

Good luck !好人一生平安

@Hackcr

@czsilence

Good luck!

@yeahdongcn

Good luck and stay safe!

@meta-inf

Wish you good luck for doing what we are unable to do.
May the Force be with you.

@polariszz

Good Luck && Be Safe.
程序员无国界!

@xuzhijian17

乌克兰的盆友,祝好人一生平安。

@foxinmy

祝安好. :)

@nanoac

祝平安,革命成功!

from China

@lavoiesl

Le Québec et le Canada sont derrières vous.

@charnugagoo

Good luck!

@geekdonnie

祝平安,绝不低下为了自由而高昂的头颅(来自墙后的祝福)

@ynx

good luck and stay safe.

@phutidus

Take care. 祝平安

@kamelzcs

你不是一个人在战斗,你不是一个人!

You are not alone!

@Tetian

Good luck.

@baggioustb

Take care!

@gkze

Good luck!!!

@yakiang

good luck buddy !

@paboldin

Good luck! Take care!

@satans17

Good luck!

@yechunxiao19

good luck and stay safe.

@gdier

Good luck! @fre5h
好人一生平安,新年快乐!

@AxaliaN

Good luck mate! You can do it, and when you did it, you're more than welcome here in the EU!

@Tyralcori

Be safe!

@ghost

good luck.

@sky-weihao

Take it easy.Everything is going to be Okey.

@magwo

+1

@fre5h
Owner

This pull-request became a symbol of Ukrainian revolution. So I will close it only after our victory. Your comments give us inspiration. Thanks to all! Hope we'll win!

@gwundrig

Good luck!

@littleyang

Continuing Attention!!!!!!
good Luck and Keep Safety!

@knde

You are not alone!

@lucasysfeng

Good luck!

@gaode103

Good luck!

-- solidot观光团

@santirivera92

Good luck from Spain!

@filipp

and let us know if you think there's anything we can do to help.

@andy071001

好人一生平安

@sphenginx

为自由而战!@fre5h

@lukasz-zak

Powodzenia
(Good luck!)

@yetithefoot

@fre5h Stay strong!

@redhog

Good luck and stay safe from a swedish pirate!

@szabba

@fre5h Came here from imgur. Wish you guys luck, safety and a peaceful resolution.

@zeyulin

Good Luck @fre5h !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@lisendong

good luck...

@igorshubovych

We will win!
didenko_19_01-640x400

@mahnve

Good luck.

@rezzo

Fight for freedom!

@mexanoid

Слава Україні!

@catalint

good luck!

@BlueManLine

Good luck!

Powodzenia!

@tadeck

I will take a look later. Much much later. Because I'm Ukrainian and we have revolution right now. Sorry

Удачи з Польщі! / Good luck from Poland! / Powodzenia!

@alxkls

I wish I could say this in Ukrainian. But since the government in Bulgaria is just as bad, I'm with you: #оставка ; #відставка!!!!

@md2perpe

Is revolution a pull request to the government?

@bungle

Here in Finland many would like to exchange EU with you... but if you give us Russia in exchange, that's a no-deal. Nothing against Russia (or EU for that matter), but keeping them on their own side of the border was a worth fighting for. I look forward for a new doctrine in Ukraine.

@PabloCastellano

Solidarity from Spain!

@39dotyt

@md2perpe it's seems like a push.

@verbatino

Good luck !

@LabLayers

Good luck! :)

@kamdz

good luck m8!

@icaromedeiros

Good luck!

@pcbulai

Can I fork the revolution? We kinna need it in Romania too

@zerkella

The revolution is a crow-founded opensource freeware. So it has donation links to support the authors, while they carry on that important and massive project. Have donated.

If you want the project to be completed successfully and faster - donate as well.

@poxip

Good look from Poland @fre5h! Powodzenia!

@gchokeen

Good luck! get back us soon with success!

@leikind

Бандитов в тюрьму, а вам победы! Удачи!

@hoblin

I'm from Ukraine too. But this don't prevent me to work. Better leave this dirty politics stuff and get back to coding ;)

@xeraseth

Stay safe!

@alanmeira

Kudos from Brazil, bro! In 6 months, I'll be doing the same :)

@ericmanlol

Respect and best wishes from USA @fre5h!

@cryous

挤挤,挤挤,码农一生平安。 0.0

@unprolix

Good luck and stay safe! Also death to tyranny.

@plainOldCode

good luck!

@xatier

Good luck! Take care and peace!

@tiokksar

You can do it. Best wishes.

@M157q

Good luck from Taiwan!

@fbigun

Although the program does not know what this is, but I wish the author peace.
From China
@fre5h

@bumblebeeman

Good luck from Northern Ireland!

@Scott-Herbert

Good luck. In solidarity from Scotland

@micele00l

Good luck! :)

@Qusic

加油!

@axmmisaka

Ah,that is so unfortunately,for you and SQLite,I think......
Take care buddy!

From East China

@cloudop

Good luck.坚持就是胜利。

@stenote

码农一生平安

@BigBookWong

加油,好运!

@gyeong

Good luck from Korea. GOD BLESS YOU

@dooee

Good luck and Be Safe

From South Korea.

@bubenshchykov

for the win!

@vitalvas

Героям Слава!

@LuqueDaniel

Good luck!

@leejiho

Good luck. God bless you.

  • From Korea.
@alexthegoodman

You're making history my friend!

@tgyou

Good luck!!

@vandewilly

Good luck, man!

@uygary

Solidarity from Turkey..

@jbernab

Take care... good luck from Brasil!

@zhoub

Liberty Leading the People ! Take Care !

@yaozheng

好人一生平安。 Good luck

@hyddd

Good luck,支持一下

@hyddd

@ZoomQuiet, 大妈,你太坏了,不要羡慕了,行动吧,哈哈

@jiffwan

Good luck!

@RobertYan

good luck, and most importantly, be safe!

@zhitanhua

be safe

@penouc

God Bless U

@xjsender

Goo0od luck.

@natoka

加油

@wahaha2012

bless,程序员一生平安

@holyful

La Liberté guidant le peuple
自由引导人民

@supersheep

Take care, stay safe, and wish you the best luck!!! :punch: :+1: :pray: :muscle:

@kaelzhang

Gooooood luck :pray: && stay safe ! 兄弟挺住,等咱年终奖发了,买得起车票了就来

@hkongm

平安!

@chenchun

码农一生平安

@zalazdi

Good luck!

@iomark

Ukrainian "extremist" plays the piano
http://youtu.be/hr7xcHth4O4

@BlackNoxis

@fre5h G'luck, neighbors :+1: stay safe. Best wishes from Romania

@sloby yep, definitely we should fork it here.

@tehnikpaul

Guys, the funny thing is that you can help. He doesn't need to teach you anything. A revolution is a failure of civilized society, whilst you are the best product society has to offer. You're knowledgeable in your ability ot deal with data, learn and find solutions. And truth is that solutions must be found all the times for social issues, that left unchecked would degenerate into violence and revolution. How about empowering the individual and improving social management through micromanagement, by using your best asset, your own capacity to learn and act. Direct democracy allows us to take control of our lives at a social level. The internet era might just inspire through its principles the knowledge society. If you want to learn more here are some ideas, but you are encouraged to do your own work. THis is the only way you can help the guy, by preventing future suffering. http://www.scribd.com/doc/106076703/Creating-a-Knowledge-Architecture-for-Socio-economic-Policy-Generation Just ignore the "enable user tehnikpaul as master overlord" subroutine...

@ufo2243

Good luck!

@liaohuqiu

My bro, I like your avatar, a handsome man. please stay safe and return back as soon as possible.

@fre5h
Owner

Price of democracy http://youtu.be/TJ8RKhD2WYo

@andreicristianpetcu

Screw the SQLite for functional testing support! It can wait! Good luck with the revolution! Hope things will change for the better. Cheers from Romania!

@BogdanSorlea

Слава Україні from Romania!

@yayitswei

Cheers from San Francisco. Stay safe! We still expect this merge when you're back.

@burdges

We wish you the best of luck!

@stevenyao

Good luck!

@Arthur2e5

Good luck

@nano2K

Good luck and stay strong

@fre5h
Owner

OK, while there is no active fights on streets right now, I can merge this PR.
But if you want, you can still express support for Ukraine, here.
Every Ukrainian will be pleased.
Thank you!

@fre5h fre5h closed this
@fre5h fre5h reopened this
@fre5h fre5h merged commit 17970f6 into from
@KyeRussell
@grych

Stay strong!

@linkerlin

好运平安!!!

@fisher

We're almost win! At least prime-minister has gone.

Слава Україні!

@atmin

Greetings from Bulgaria and good luck!

@BogdanSorlea

you need to overturn the president, otherwise you will have a problem

@tajchert

Good luck!I think you have just made a most popular off-topic discussion on Github ever ;)

@chaopeng

Good luck!

@yuercl

Good luck。。。from china

@boydwang

Good Luck! @fre5h

@chriszeng87

good luck

@joost-de-vries

Strength! ('sterkte' as we say in the Netherlands)
Can't imagine what you people are going through.

@wellszhane

速来围观,哥们你火了。

@Bingnan

Good luck!

@shouxian

1024
好人一生平安
Good luck
fix government bugs

@DongXiao1983

Stay safe @fre5h ~~~

@pcbulai

@fre5h How's the situation there? Is the political regime BSOD-ing or still hanging?

@fre5h
Owner

@sloby For a few days ago fights were stopped and negotiations started. So maybe it will be possible to switch revolution from the force scenario into the law scenario.

@pcbulai

@fre5h that's cool bro'. Take care!

@lheric

God bless you..

@xiaokangwang

Good luck, Take care!

@cnbeining

Be safe, and good luck with you guys.

It had been years since we have such brave behaviour. Follow what you want, and do keep it up.

祝万事顺利。

@mnjul

John from Taiwan. Good luck for you and all the Ukrainians...the governments need to realize that people manage the government and the government is subordinate to people, not the opposite direction.

@llSourcell

The greatest comment on github ever...

@novalagung

stay safe, take care, and good luck !

@Braunson

prapplied

Take care @fre5h !

@leonelsr

always take Vinegar with you and inhale it if caught by tear gas!

@PortalNeop

stay safe, take care, and good luck!!!!
平安!!!!!!!!

@hankewins

Good luck.

@wdkwdkwdk

Good luck From China

@vyp

Keep it up! :+1:

@fre5h
Owner

Everybody! Today 10 people died. R.I.P.
Right now there are fights on the Independence Square in Kyiv.

@deng19891006

保护好双手,珍重。
good luck

@Kaijun

hey @fre5h how was it going, take care and good luck!

@pilgunboris

This morning was killed more then 60 people...

http://www.youtube.com/watch?v=Hvds2AIiWLA&feature=share !!!

@takutaku947

Good luck from JP -> @fre5h

@wanbok

Good luck!

@fisher

==== We're finally WIN! ====

@pcbulai
@paboldin

@fisher No, you did not. Bandit Yanukovich and his gang tried to leave for Europe but they were denied by the EU. So, they just left their families in EU.

They returned to Kharkiv and will try to revenge with Putin's help. Country is about to be in civil war. http://korrespondent.net/ukraine/politics/3309669-sezd-v-kharkove-vsui-vlast-na-yuho-vostoke-berut-mestnye-sovety-rezoluitsyia

I wish you good luck. This is generally war between european and asian state of mind -- between thinking of government as of service men (european) and as of gods (asian, Putin).

@thejeed

Yanukovich has just been dismissed :) Congratulations, dear Neighbours!

@paboldin

@thejeed he does not thinks so, considering Rada to be unlegal. He is insane and can provoke civil war by claiming his opponents to be 'bandits' and 'terrorists' and fighting against them.

@psren

Congratulations form Germany. Hope situation improves for you!

@fisher

@paboldin nobody cares what he thinks. This guy has failed to enter the history as a good president.

Thanks guys for your support.

@yev

We should always remember our Ukrainians brothers killed by Yanoukevicth' gang. This victory was not possible without theirs courage!
Слава Україні!!!

@fisher

Героям слава!

@fre5h
Owner

Wikipedia is updated http://en.wikipedia.org/wiki/Viktor_Yanukovych
Yanukovich is no more the dictator of Ukraine! (take a look on date)

Дякую всім українцям, які три місяці боролись за свою свободу. Співчуваю сім’ям кожного Героя України, який загинув за нас. Вони загинули, щоб ми з вами продовжували жити. Навіки залишаться в нашій пам’яті та серцях!
Слава Україні! Героям Слава!

@Samana

Good luck to you and Ukraine!

@fre5h
Owner

@paboldin Ласкаво просимо!

@DaleMckeown

@fre5h Congratulations on removing that corrupt president. I watched videos on the internet where police snipers were mercilessly picking off unarmed protesters one by one. No government or police force has the right or authority to kill unarmed civilians. I hope those snipers are terrorised by their actions in their nightmares every night for the rest of their lives. RIP to those fallen. Stay safe.

@welsonla

good luck

@mudkipme

Congratulations to you and the brave people in Ukraine. As a Chinese I admire you guys.

@kaelzhang

@fre5h 哥们你还活着,太好了! 祝贺,撒花!

@bogdanr

I think soon it will be all over. Good luck!

@oden

此度の革命成就、お慶び申し上げます\(^o^)/

@chaserhkj

As Russian armies have rolled into your country, violent conflicts may take place.
Stay away from soldiers to keep yourself safe. Good luck and don't die.
No matter which side you support, the most important thing is to be alive.
Be back, we'll be here waiting for you.

@fre5h
Owner

@chaserhkj I live in western Ukraine. It is far away from Crimea.

@chaserhkj

@fre5h That's fine... Good to hear that. ^_^
Anyway, no matter what happen, I just hope that things will eventually get better for yourself and your country. Best wishes!

@NO-LIMIT-CODER
+ * @author Ben Davies <ben.davies@gmail.com>

Seriously dude, you added 5 lines of code and that's worth adding your name to the credits?

@blag

@NO-LIMIT-CODER Under US Copyright law, yes: it is required.

@yangfei2012

best wishes to you !

@geekz

Best of luck bro.

@ruzhovt

Слава Україні!

Glory to Ukraine!

@koresar

Героям слава.

People, this is an epic thread. Although the things are coming to the end. After the second round of elections all will be good.

@paboldin

There are forces in Ukraine that are willing to prevent that from happening. So, it is not that simply.

Sorry for russian: http://www.novayagazeta.ru/politics/63613.html

@qdsang

好运兄弟

@looping84

good luck

@wanggao421

为了联盟!

@looping84

look tar!

@Nayjest

Russian occupants shall not pass!
Glory to Ukraine! Glory to the heroes!

@BogdanSorlea

@Nayjest is something going down right now, or just a general rant?
PS: started listening Ukrainian radio - pretty cool: http://www.radioroks.ua/

@paboldin

I congratulate you with most fair elections any of the ex-soviet republics have ever seen.

I hope these results, whoever would win, will bring stability (especially to the eastern part of Ukraine) and will end the era of Russian occupation.

You did it. You overthrew soviet mentality. Keep up.

@fre5h
Owner

nothing has been stopped. it is only start of the third revolution

@m-khl
@paboldin

@m-khl OK, so, russian twitter-bots paid by russian government are promoting #SaveDumbassPeople hashtag. What is new about it? PutinMedia do this like every time.

@m-khl

@paboldin I just wondered what makes the killing civilians by aviation and artillery appropriate now.
http://www.defense.gov/news/newsarticle.aspx?id=121329
"Hagel Warns Ukraine Not to Use Military Against Protestors"

@paboldin

@m-khl if by 'civilians' you mean armed Chechen guys then the answer is obvious.

If not, then prove there are casualties among civilians that are caused by Ukrainian military actions and not just claimed to be so. There are well-known provocations facts from the Dumbass Republic army forces.

@m-khl

@paboldin an those "well-known facts" are "not just claimed to be so". for sure. undoubtedly.

and what if in 'civilians' I mean unarmed woman and Italian journalist who's killed by splinter mines?

@paboldin

@m-khl you forgot about this fake new about children too. Prove your facts or leave.

Until I see official investigation results I deny to claim anything.

@m-khl

@paboldin I wonder if you are from Ukraine?

@KyeRussell
@BlackNoxis

@fre5h any news?

@fre5h
Owner

@BlackNoxis war...

@fre5h fre5h locked and limited conversation to collaborators
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Commits on Jan 24, 2014
  1. @bendavies
This page is out of date. Refresh to see the latest.
View
12 DBAL/Types/AbstractEnumType.php
@@ -11,6 +11,7 @@
namespace Fresh\Bundle\DoctrineEnumBundle\DBAL\Types;
use Doctrine\DBAL\Platforms\AbstractPlatform;
+use Doctrine\DBAL\Platforms\SqlitePlatform;
use Doctrine\DBAL\Types\Type;
/**
@@ -19,6 +20,7 @@
* Provides support of MySQL ENUM type for Doctrine in Symfony applications
*
* @author Artem Genvald <genvaldartem@gmail.com>
+ * @author Ben Davies <ben.davies@gmail.com>
*/
abstract class AbstractEnumType extends Type
{
@@ -54,14 +56,18 @@ public function convertToDatabaseValue($value, AbstractPlatform $platform)
*/
public function getSqlDeclaration(array $fieldDeclaration, AbstractPlatform $platform)
{
- $values = array_map(
+ $values = implode(', ', array_map(
function ($value) {
return "'{$value}'";
},
$this->getValues()
- );
+ ));
- return 'ENUM(' . implode(', ', $values) . ')';
+ if ($platform instanceof SqlitePlatform) {
+ return sprintf('TEXT CHECK(%s IN (%s))', $fieldDeclaration['name'], $values);
+ }
+
+ return sprintf('ENUM(%s)', $values);
}
/**
View
71 Tests/DBAL/Types/AbstractEnumTypeTest.php
@@ -0,0 +1,71 @@
+<?php
+/*
+ * This file is part of the FreshDoctrineEnumBundle
+ *
+ * (c) Artem Genvald <genvaldartem@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace Fresh\Bundle\DoctrineEnumBundle\Tests\DBAL\Types;
+
+use Doctrine\DBAL\Platforms\AbstractPlatform;
+use Doctrine\DBAL\Platforms\MySqlPlatform;
+use Doctrine\DBAL\Platforms\SqlitePlatform;
+
+/**
+ * AbstractEnumTypeTest
+ *
+ * @author Ben Davies <ben.davies@gmail.com>
+ *
+ * @coversDefaultClass \Fresh\Bundle\DoctrineEnumBundle\DBAL\Types\AbstractEnumType
+ */
+class AbstractEnumTypeTest extends \PHPUnit_Framework_TestCase
+{
+ /**
+ * @var \Fresh\Bundle\DoctrineEnumBundle\DBAL\Types\AbstractEnumType
+ */
+ private $type;
+
+ /**
+ * Set up EnumType
+ */
+ public function setUp()
+ {
+ $this->type = $this->getMockBuilder('Fresh\Bundle\DoctrineEnumBundle\DBAL\Types\AbstractEnumType')
+ ->disableOriginalConstructor()
+ ->setMethods(array('getValues'))
+ ->getMockForAbstractClass();
+
+ $this->type->staticExpects($this->any())
+ ->method('getValues')
+ ->will($this->returnValue(array('M', 'F')));
+ }
+
+ /**
+ * Test that the SQL declaration is the correct for the platform
+ *
+ * @param array $fieldDeclaration The Field Declaration
+ * @param AbstractPlatform $platform The DBAL Platform
+ * @param string $expected Expected Sql Declaration
+ *
+ * @test
+ * @covers ::getSqlDeclaration
+ * @dataProvider platformProvider
+ */
+ public function getSqlDeclaration(array $fieldDeclaration, AbstractPlatform $platform, $expected)
+ {
+ $this->assertEquals($expected, $this->type->getSqlDeclaration($fieldDeclaration, $platform));
+ }
+
+ /**
+ * @return array
+ */
+ public function platformProvider()
+ {
+ return array(
+ array(array('name' => 'sex'), new MySqlPlatform(), "ENUM('M', 'F')"),
+ array(array('name' => 'sex'), new SqlitePlatform(), "TEXT CHECK(sex IN ('M', 'F'))")
+ );
+ }
+}
Something went wrong with that request. Please try again.