dash: route v36 COMBINED_DONATION_SCRIPT onto cross-coin core::donation SSOT (Bucket-2 dedup) - #533
Merged
Merged
Conversation
…on SSOT Pillar-4 of the v36-migration-std sweep (donation P2SH). DASH kept a hand-copied local literal of the unified v36 P2SH instead of consuming the cross-coin single-source core::donation::COMBINED_DONATION_SCRIPT that btc already references. The bytes were identical, but a per-coin literal copy is exactly the v36 dialect-drift the 3-bucket rule flags as a Bucket-2 standardization target: the v36 donation script is a SHARED v36-native shape, not a DASH isolation primitive, so it must stay byte-identical to btc/bch/dgb/ltc and should derive from the SSOT. Rewire is value-invariant: COMBINED_DONATION_SCRIPT now initializes from core::donation::COMBINED_DONATION_SCRIPT (proven byte-identical to the prior literal and to a914<8c627262..8e85>87 by the new lock KAT). The pre-v36 DASH-specific P2PKH DONATION_SCRIPT (Bucket-3, oracle-conformant, kept for the soak) is untouched. current_share_version stays 16, so no live share changes shape. Adds DashConformanceCombinedDonation.MatchesCrossCoinSSOT. Full dash conformance suite 47/47 green on Linux x86_64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pillar-4 of the v36-migration-std sweep — donation P2SH.
DASH kept a hand-copied local literal of the unified v36 P2SH in
src/impl/dash/share_check.hppinstead of consuming the cross-coin single-sourcecore::donation::COMBINED_DONATION_SCRIPTthat btc already references. The bytes were identical, but a per-coin literal copy is exactly the v36 dialect-drift the operator 3-bucket rule flags as a Bucket-2 standardization target: the v36 donation script is a SHARED v36-native shape, not a DASH isolation primitive, so it must stay byte-identical to btc/bch/dgb/ltc and should derive from the SSOT (clean v37 migration).Change (value-invariant)
COMBINED_DONATION_SCRIPTnow initializes fromcore::donation::COMBINED_DONATION_SCRIPTinstead of a literal byte array — proven byte-identical to the prior literal and toa914<8c627262..8e85>87.DONATION_SCRIPT(Bucket-3, oracle-conformant per frstrtr/p2pool-dash data.py:66, kept for the soak) is untouched.current_share_versionstays 16 → no live share changes shape.Conformance verdict (pillar-4)
76a91420cb5c22..88ac, XdgF55w…) — CONFORMANT (Bucket-3).Tests
Adds
DashConformanceCombinedDonation.MatchesCrossCoinSSOT(locks dash == core SSOT == expected 23-byte P2SH). Full dash conformance 47/47 green on Linux x86_64.Scope: 2 files, DASH-isolated (dash impl + dash test); consumes the existing core SSOT, does not modify
core/. No build.yml allowlist change (test_dash_conformance already targeted). Held for integrator verify → operator tap; no self-merge.