dash(version-gate): route 60%/95% gate literals to named v36-native thresholds (Bucket-2 SSOT dedup) - #536
Merged
Conversation
…hresholds (Bucket-2 SSOT dedup) version_negotiation.hpp re-spelled the v36-native successor-switch (60%) and v36-activation-signal (95%) percentages as bare uint288 literals at the gate call sites, even though UNIFIED_SUCCESSOR_PCT=60 was already declared (lower in the same file, used only by the 3-arg crossing overload). Hoist the three threshold constants to the top of the namespace and route both gates through the named constants -- the same per-coin dialect-drift removal #533 applied to the donation script, now for the version gate. Value-invariant: 60/95/85 unchanged; uint288 exact-rational arithmetic untouched; zero core/ edit; DASH-isolated; no build.yml allowlist change. New KAT pins the named constants to canonical values and re-confirms the 60/95/85 boundaries are byte-identical through the named path. 49/49 test_dash_conformance green on Linux x86_64. Cross-coin hoist of these percentages into core::version_gate (which today owns only the =36 boundary) is a coordinated follow-up flagged to decisions@; this slice keeps DASH internally single-sourced without touching btc/dgb call sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
v36-migration-std sweep, pillar-5 (share-version-weighting / desired_version gate).
version_negotiation.hppre-spelled the v36-native successor-switch (60%) and v36-activation-signal (95%) percentages as bareuint288literals at the gate call sites — even thoughUNIFIED_SUCCESSOR_PCT = 60was already declared lower in the same file (used only by the 3-arg crossing overload). This is the same per-coin dialect-drift #533 removed for the donation script, now for the version gate.This slice hoists the three threshold constants to the top of the namespace and routes both gates through them:
successor_switch_allowed→UNIFIED_SUCCESSOR_PCT(60)v36_active→V36_SIGNAL_ACTIVATION_PCT(95, newly named)CROSSING_SUCCESSOR_FLOOR_PCT(85) hoisted alongside (Bucket-3, unchanged)Why it is safe
core/edit, nobuild.ymlallowlist change (test_dash_conformancealready listed).DashVersionGateThresholdSSOTpins the named constants to canonical values (so a future edit cannot silently fork the gate) and re-confirms the 60/95/85 boundaries are byte-identical through the named path.test_dash_conformancegreen on Linux x86_64 (+2 new, non-hollow).Classification (3-bucket)
core::version_gate(which today owns only the=36boundary, not the percentages — btc/dgb also re-spell 60/95 as bare literals) is a coordinated follow-up flagged to decisions@, deliberately not done here to avoid colliding with the BTC/DGB lanes.CROSSING_SUCCESSOR_FLOOR_PCTstays Bucket-3 (per-coin, temporary, dropped post-soak).Oracle-conformant (frstrtr/p2pool-dash); held for integrator verify → operator tap. No self-merge.