Skip to content

Conversation

@eiriktsarpalis
Copy link
Contributor

I added this option to the AST compiler methods in order to work around this issue in my QuotationCompiler library.

@7sharp9
Copy link
Member

7sharp9 commented Jul 2, 2015

So this removes an implicit FSharp.Core reference?

@eiriktsarpalis
Copy link
Contributor Author

Yes, same as --noframework in fsc.exe.

@7sharp9
Copy link
Member

7sharp9 commented Jul 2, 2015

@dsyme Why is there no Compile* methods in normal SourceCodeServices?

I think that the API should be normalised that way, its annoying to have to create another type to Compile when you are already using FsharpChecker in SourceCodeServices which essentially the same API.

@dsyme
Copy link
Contributor

dsyme commented Jul 2, 2015

@7sharp9 - yes, it would be reasonable to bring the Compile methods into FSharpChecker. For starters that could then help ensure the same Reactor thread is used for both checking and compilation.

@dsyme
Copy link
Contributor

dsyme commented Jul 2, 2015

This fix is good enough considering it only affects the compile-from-AST methods.

There is certainly duplication between the AST and compile-from-text paths which ideally should be resolved in the future, e.g. the command-line arguments governing the compilation (such as noframework) should probably come inn textual form, for uniformity with the rest of the compiler services. But that would be a different commit.

So I'm ok to merge this.

dsyme added a commit that referenced this pull request Jul 2, 2015
Add noframework option in AST compiler methods
@dsyme dsyme merged commit 5cea4e1 into fsharp:master Jul 2, 2015
@eiriktsarpalis
Copy link
Contributor Author

Thanks. Looking forward for a nuget package update!

@eiriktsarpalis eiriktsarpalis deleted the add-noframework-option branch July 2, 2015 20:31
dsyme added a commit to dsyme/FSharp.Compiler.Service that referenced this pull request Jul 8, 2015
…error

fixes fsharp#362
closes fsharp#430

commit 22bf8ebf25de08905342d5984052b683479e5a65
Author: Don Syme <donsyme@fastmail.fm>
Date:   Sat May 9 12:08:27 2015 +0100

    fix 362

commit bc28158073b8605dc03a0816a1679a729595fda0
Author: Don Syme <donsyme@fastmail.fm>
Date:   Sat May 9 12:06:27 2015 +0100

    fix 362 (2)

commit 6bfdeac2c8718032be43c75c6a09ea66866bbbc5
Author: Don Syme <donsyme@fastmail.fm>
Date:   Sat May 9 11:58:48 2015 +0100

    fix 362
fsgit added a commit that referenced this pull request Jul 31, 2015
Delete Microsoft.Portable.FSharp.targets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants