Exposing implemented abstract slots #430
Conversation
Previously only declarations in the last code file was visible
|
The terminology in the symbols API is strange, "abstract slot signatures" sounds far more technical than it needs to. |
|
@7sharp9 Can you suggest some better naming? Thanks! |
…error fixes fsharp#362 closes fsharp#430 commit 22bf8ebf25de08905342d5984052b683479e5a65 Author: Don Syme <donsyme@fastmail.fm> Date: Sat May 9 12:08:27 2015 +0100 fix 362 commit bc28158073b8605dc03a0816a1679a729595fda0 Author: Don Syme <donsyme@fastmail.fm> Date: Sat May 9 12:06:27 2015 +0100 fix 362 (2) commit 6bfdeac2c8718032be43c75c6a09ea66866bbbc5 Author: Don Syme <donsyme@fastmail.fm> Date: Sat May 9 11:58:48 2015 +0100 fix 362
src/fsharp/infos.fs
Outdated
There was a problem hiding this comment.
The "Value" might fail here (MemberInfo is an option). (When the value is not a member then "ImplementedSlotSigs" in the symbols API should I think return an empty list or at least give a good exception?).
|
This looks good. I'm surprised at the AppVeyor build failure w.r.t. SourceLink - ideally that part of the build shouldn't be being run on appveyor. |
|
@Jand42 Could you please add tests for the abstract slot signatures? Thanks |
|
@dsyme Added some tests and fixed possibly failing |
|
Sorry for the extra commits. |
Exposing implemented abstract slots
|
Thanks for the great contribution |
3 participants
New classes are added to expose SlotSig and SlotParam typed in Symbols API. Previously there was no way to tell which abstract slot an override or an interface implementation member were using.
Also there is a small fix included to have all assembly-level attributes visible on FSharpAssemblySignature.Attributes, not just the ones declared in the last code file.